You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/28 23:18:34 UTC

[GitHub] [commons-dbcp] garydgregory opened a new pull request #81: Dbcp 567 cleanups

garydgregory opened a new pull request #81:
URL: https://github.com/apache/commons-dbcp/pull/81


   There are further clean ups post merge of the main PR and secondary PR.
   
   This undoes PoolableConnectionFactory having been made AutoCloseable in the main PR, which is no longer needed since the new close() method is now a NOP.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-dbcp] garydgregory closed pull request #81: Dbcp 567 cleanups

Posted by GitBox <gi...@apache.org>.
garydgregory closed pull request #81:
URL: https://github.com/apache/commons-dbcp/pull/81


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-dbcp] garydgregory commented on pull request #81: Dbcp 567 cleanups

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #81:
URL: https://github.com/apache/commons-dbcp/pull/81#issuecomment-751893445


   Hm, I must have messed up something because I see 6 commits instead of one. Fixing...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [commons-dbcp] garydgregory commented on pull request #81: Dbcp 567 cleanups

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #81:
URL: https://github.com/apache/commons-dbcp/pull/81#issuecomment-751893341


   Looking for feedback from @rmannibucau and/or @psteitz .


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org