You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/28 01:54:38 UTC

[GitHub] [flink-kubernetes-operator] tweise commented on pull request #281: [FLINK-26891] Record important deployment events

tweise commented on PR #281:
URL: https://github.com/apache/flink-kubernetes-operator/pull/281#issuecomment-1168120050

   > Nice job, @tweise! I was wondering if we could/should make the Reason field part of the FlinkResourceListener API? If we do so a call control layer could leverage it and could build some business logic on top of it. Even if we don't make it part of the API yet an enum type with the possible reason values would enforce some naming convention and consistency. What do you think?
   
   Great suggestion. We could make the reason codes an enum similar to component and type. How about we then also change the signature of `triggerEvent` to use the enum instead of string?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org