You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/10 05:51:57 UTC

[GitHub] dongjoon-hyun commented on issue #23756: [SPARK-26853][SQL] Add example and version for commonly used aggregate function descriptions

dongjoon-hyun commented on issue #23756: [SPARK-26853][SQL] Add example and version for commonly used aggregate function descriptions
URL: https://github.com/apache/spark/pull/23756#issuecomment-462106262
 
 
   @dilipbiswal . As we know, here is [a list of registered aggregation functions](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala#L280-L312).
   
   Since this PR touchs `approx_percentile`, can we update `approx_count_distinct`, too? In general, the followings are commonly used, too.
   
   - `collect_list`, `collect_set`
   - `std (=stddev_samp)`, `stddev_pop`
   - `variance (=var_samp)`, `var_pop`
   - `covar_samp`, `covar_pop`
   - `percentile`
   
   I'm wondering if you can review the list and add examples for all aggregation functions for Apache Spark 3.0.0. How do you think about that?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org