You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2008/08/20 22:52:44 UTC
[jira] Created: (THRIFT-118) Improved inspect for Ruby structs
Improved inspect for Ruby structs
---------------------------------
Key: THRIFT-118
URL: https://issues.apache.org/jira/browse/THRIFT-118
Project: Thrift
Issue Type: Sub-task
Components: Compiler (Ruby), Library (Ruby)
Reporter: Bryan Duxbury
Assignee: Bryan Duxbury
Attachments: thrift-118.patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-118) Improved inspect for Ruby structs
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625829#action_12625829 ]
Kevin Clark commented on THRIFT-118:
------------------------------------
This looks great. I expect you didn't mean to include the line removing jikes from AX_PROG_JAVAX?
> Improved inspect for Ruby structs
> ---------------------------------
>
> Key: THRIFT-118
> URL: https://issues.apache.org/jira/browse/THRIFT-118
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (Ruby), Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-118-v2.patch, thrift-118.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-118) Improved inspect for Ruby structs
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625831#action_12625831 ]
Bryan Duxbury commented on THRIFT-118:
--------------------------------------
No, though I certainly wouldn't mind not having to remove that line manually every time I update to get make to run correctly... :)
> Improved inspect for Ruby structs
> ---------------------------------
>
> Key: THRIFT-118
> URL: https://issues.apache.org/jira/browse/THRIFT-118
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (Ruby), Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-118-v2.patch, thrift-118.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-118) Improved inspect for Ruby structs
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-118:
---------------------------------
Attachment: thrift-118.patch
Here's a cut at the ruby version.
I had to modify the generator to provide the information about which fields were optional, but the rest is implemented in the library.
> Improved inspect for Ruby structs
> ---------------------------------
>
> Key: THRIFT-118
> URL: https://issues.apache.org/jira/browse/THRIFT-118
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (Ruby), Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-118.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-118) Improved inspect for Ruby structs
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Clark closed THRIFT-118.
------------------------------
Resolution: Fixed
Pushed in 689193.
> Improved inspect for Ruby structs
> ---------------------------------
>
> Key: THRIFT-118
> URL: https://issues.apache.org/jira/browse/THRIFT-118
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (Ruby), Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-118-v2.patch, thrift-118.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-118) Improved inspect for Ruby structs
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-118:
---------------------------------
Patch Info: [Patch Available]
> Improved inspect for Ruby structs
> ---------------------------------
>
> Key: THRIFT-118
> URL: https://issues.apache.org/jira/browse/THRIFT-118
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (Ruby), Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-118.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-118) Improved inspect for Ruby structs
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury updated THRIFT-118:
---------------------------------
Attachment: thrift-118-v2.patch
This version includes some spec coverage for the changes to each_field
> Improved inspect for Ruby structs
> ---------------------------------
>
> Key: THRIFT-118
> URL: https://issues.apache.org/jira/browse/THRIFT-118
> Project: Thrift
> Issue Type: Sub-task
> Components: Compiler (Ruby), Library (Ruby)
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Attachments: thrift-118-v2.patch, thrift-118.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.