You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2022/11/05 16:13:46 UTC
[GitHub] [submarine] hhcs9527 opened a new pull request, #1012: SUBMARINE-1296. Add create user function when register a new user.
hhcs9527 opened a new pull request, #1012:
URL: https://github.com/apache/submarine/pull/1012
### What is this PR for?
<!-- A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://submarine.apache.org/contribution/contributions.html
-->
Originally we are unable to create user correctly, We add create user function when registering a new user in this PR.
### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
Bug Fix
### Todos
* [ ] - Task
### What is the Jira issue?
[SUBMARINE-1293](https://issues.apache.org/jira/browse/SUBMARINE-1293)
### How should this be tested?
<!--
* First time? Setup Travis CI as described on https://submarine.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
-->
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] codecov[bot] commented on pull request #1012: SUBMARINE-1296. Add create user function when register a new user.
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #1012:
URL: https://github.com/apache/submarine/pull/1012#issuecomment-1304576092
# [Codecov](https://codecov.io/gh/apache/submarine/pull/1012?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1012](https://codecov.io/gh/apache/submarine/pull/1012?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e118d81) into [master](https://codecov.io/gh/apache/submarine/commit/bc4bf08864ccd0a966f05c79936790f8ba1ff104?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bc4bf08) will **increase** coverage by `21.50%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1012 +/- ##
=============================================
+ Coverage 25.47% 46.98% +21.50%
=============================================
Files 358 112 -246
Lines 29088 4944 -24144
Branches 3479 0 -3479
=============================================
- Hits 7411 2323 -5088
+ Misses 21463 2621 -18842
+ Partials 214 0 -214
```
| Flag | Coverage Δ | |
|---|---|---|
| python-integration | `?` | |
| python-unit | `46.98% <ø> (-5.20%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/submarine/pull/1012?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ine-sdk/pysubmarine/submarine/models/tensorflow.py](https://codecov.io/gh/apache/submarine/pull/1012/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbW9kZWxzL3RlbnNvcmZsb3cucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dk/pysubmarine/submarine/ml/tensorflow/model/fm.py](https://codecov.io/gh/apache/submarine/pull/1012/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbWwvdGVuc29yZmxvdy9tb2RlbC9mbS5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...k/pysubmarine/submarine/ml/tensorflow/model/nfm.py](https://codecov.io/gh/apache/submarine/pull/1012/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbWwvdGVuc29yZmxvdy9tb2RlbC9uZm0ucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../pysubmarine/submarine/ml/tensorflow/parameters.py](https://codecov.io/gh/apache/submarine/pull/1012/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbWwvdGVuc29yZmxvdy9wYXJhbWV0ZXJzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../pysubmarine/submarine/ml/tensorflow/registries.py](https://codecov.io/gh/apache/submarine/pull/1012/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbWwvdGVuc29yZmxvdy9yZWdpc3RyaWVzLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ysubmarine/submarine/ml/tensorflow/model/deepfm.py](https://codecov.io/gh/apache/submarine/pull/1012/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbWwvdGVuc29yZmxvdy9tb2RlbC9kZWVwZm0ucHk=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ubmarine/submarine/ml/tensorflow/input/\_\_init\_\_.py](https://codecov.io/gh/apache/submarine/pull/1012/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbWwvdGVuc29yZmxvdy9pbnB1dC9fX2luaXRfXy5weQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ine/submarine/ml/tensorflow/model/base\_tf\_model.py](https://codecov.io/gh/apache/submarine/pull/1012/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbWwvdGVuc29yZmxvdy9tb2RlbC9iYXNlX3RmX21vZGVsLnB5) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../pysubmarine/submarine/ml/tensorflow/model/ccpm.py](https://codecov.io/gh/apache/submarine/pull/1012/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbWwvdGVuc29yZmxvdy9tb2RlbC9jY3BtLnB5) | `0.00% <0.00%> (-96.78%)` | :arrow_down: |
| [...pysubmarine/submarine/ml/tensorflow/layers/core.py](https://codecov.io/gh/apache/submarine/pull/1012/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VibWFyaW5lLXNkay9weXN1Ym1hcmluZS9zdWJtYXJpbmUvbWwvdGVuc29yZmxvdy9sYXllcnMvY29yZS5weQ==) | `0.00% <0.00%> (-83.53%)` | :arrow_down: |
| ... and [281 more](https://codecov.io/gh/apache/submarine/pull/1012/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] hhcs9527 commented on pull request #1012: SUBMARINE-1296. Add create user function when register a new user.
Posted by GitBox <gi...@apache.org>.
hhcs9527 commented on PR #1012:
URL: https://github.com/apache/submarine/pull/1012#issuecomment-1304711374
@cdmikechen please take a look at the pr, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #1012: SUBMARINE-1296. Add create user function when register a new user.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1012: SUBMARINE-1296. Add create user function when register a new user.
URL: https://github.com/apache/submarine/pull/1012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org