You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/16 12:32:37 UTC
[GitHub] [airflow] msumit opened a new pull request #11573: Fix migration for Sqlite3
msumit opened a new pull request #11573:
URL: https://github.com/apache/airflow/pull/11573
While setting up SQLite DB with Airflow 2.0, got the below error. Not sure how this was hidden from @ashb or CI, or maybe something wrong with my setup only?
`sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) no such column: true`
`[SQL: UPDATE dag SET concurrency=16, has_task_concurrency_limits=true where concurrency IS NULL]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #11573: Fix migration for Sqlite3
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #11573:
URL: https://github.com/apache/airflow/pull/11573#issuecomment-710019833
Oh migration. We don't test those in CI, at least not with data in the db
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #11573: Fix migration for Sqlite3
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #11573:
URL: https://github.com/apache/airflow/pull/11573#issuecomment-710019347
Curious, maybe we don't test task concurrency limits in CI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #11573: Fix migration for Sqlite3
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #11573:
URL: https://github.com/apache/airflow/pull/11573#issuecomment-710050961
It won't, I'll manually test this. Please hold off on merging just yet
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #11573: Fix migration for Sqlite3
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #11573:
URL: https://github.com/apache/airflow/pull/11573#issuecomment-710051295
Turns out it does test it - and it doesn't work on postgres
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] msumit merged pull request #11573: Fix migration for Sqlite3
Posted by GitBox <gi...@apache.org>.
msumit merged pull request #11573:
URL: https://github.com/apache/airflow/pull/11573
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] msumit commented on pull request #11573: Fix migration for Sqlite3
Posted by GitBox <gi...@apache.org>.
msumit commented on pull request #11573:
URL: https://github.com/apache/airflow/pull/11573#issuecomment-710219874
> Perhaps using https://docs.sqlalchemy.org/en/13/core/sqlelement.html?highlight=true#sqlalchemy.sql.expression.true ?
Got the same error when I blindly tried to use `sa.true()`.. so finally updating values as per a if condition..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #11573: Fix migration for Sqlite3
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #11573:
URL: https://github.com/apache/airflow/pull/11573#issuecomment-710078038
Perhaps using https://docs.sqlalchemy.org/en/13/core/sqlelement.html?highlight=true#sqlalchemy.sql.expression.true ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] msumit commented on pull request #11573: Fix migration for Sqlite3
Posted by GitBox <gi...@apache.org>.
msumit commented on pull request #11573:
URL: https://github.com/apache/airflow/pull/11573#issuecomment-710021764
> Oh migration. We don't test those in CI, at least not with data in the db
Ohh, in that it won't test if the changed statement works well with Mysql or Postgres or not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org