You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "clownxc (via GitHub)" <gi...@apache.org> on 2023/03/26 11:37:41 UTC

[GitHub] [hudi] clownxc opened a new pull request, #8295: [HUDI-5893] Mark advanced configs

clownxc opened a new pull request, #8295:
URL: https://github.com/apache/hudi/pull/8295

   ### Change Logs
   
   Some of configs should be marked advanced (https://github.com/apache/hudi/pull/7709). This PR mark the configs:
   - hoodie.archive.automatic
   - hoodie.archive.async
   - hoodie.bloom.index.bucketized.checking
   - hoodie.avro.schema
   
   
   
   ### Impact
   
   makes it easier to use Hudi, especially as a beginner
   ### Risk level (write none, low medium or high below)
   
   none
   ### Documentation Update
   
   This will be used for grouping configs on the website, Documentation Need to make changes to the website to show advanced configs.
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8295: [HUDI-5893] Mark advanced configs

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8295:
URL: https://github.com/apache/hudi/pull/8295#issuecomment-1484112898

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "75443b06a0d720f099e8f4ca0d6e77674e58cd83",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15924",
       "triggerID" : "75443b06a0d720f099e8f4ca0d6e77674e58cd83",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 75443b06a0d720f099e8f4ca0d6e77674e58cd83 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15924) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8295: [HUDI-5893] Mark advanced configs

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8295:
URL: https://github.com/apache/hudi/pull/8295#issuecomment-1484082306

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "75443b06a0d720f099e8f4ca0d6e77674e58cd83",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15924",
       "triggerID" : "75443b06a0d720f099e8f4ca0d6e77674e58cd83",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 75443b06a0d720f099e8f4ca0d6e77674e58cd83 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=15924) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] clownxc commented on pull request #8295: [HUDI-5893] Mark advanced configs

Posted by "clownxc (via GitHub)" <gi...@apache.org>.
clownxc commented on PR #8295:
URL: https://github.com/apache/hudi/pull/8295#issuecomment-1492483015

   > @clownxc Thanks for putting this up! LGTM. I plan to mark more advanced configs following this.
   
   Thank you very much for review. my first contribution to hudi :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on a diff in pull request #8295: [HUDI-5893] Mark advanced configs

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #8295:
URL: https://github.com/apache/hudi/pull/8295#discussion_r1153588062


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -216,6 +216,7 @@ public class HoodieWriteConfig extends HoodieConfig {
   public static final ConfigProperty<String> AVRO_SCHEMA_STRING = ConfigProperty
       .key("hoodie.avro.schema")
       .noDefaultValue()
+      .markAdvanced()

Review Comment:
   I think this may still be used for the basic schema evolution.  Let's not make it advanced.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua merged pull request #8295: [HUDI-5893] Mark advanced configs

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua merged PR #8295:
URL: https://github.com/apache/hudi/pull/8295


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on a diff in pull request #8295: [HUDI-5893] Mark advanced configs

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #8295:
URL: https://github.com/apache/hudi/pull/8295#discussion_r1153588062


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieWriteConfig.java:
##########
@@ -216,6 +216,7 @@ public class HoodieWriteConfig extends HoodieConfig {
   public static final ConfigProperty<String> AVRO_SCHEMA_STRING = ConfigProperty
       .key("hoodie.avro.schema")
       .noDefaultValue()
+      .markAdvanced()

Review Comment:
   I think this may still be used for the basic schema evolution.  Let's not make it advanced.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #8295: [HUDI-5893] Mark advanced configs

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #8295:
URL: https://github.com/apache/hudi/pull/8295#issuecomment-1484080611

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "75443b06a0d720f099e8f4ca0d6e77674e58cd83",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "75443b06a0d720f099e8f4ca0d6e77674e58cd83",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 75443b06a0d720f099e8f4ca0d6e77674e58cd83 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on pull request #8295: [HUDI-5893] Mark advanced configs

Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #8295:
URL: https://github.com/apache/hudi/pull/8295#issuecomment-1490687552

   @clownxc Thanks for putting this up!  I'll address the comment and land the PR.  I plan to mark more advanced configs following this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org