You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dlmma <gi...@git.apache.org> on 2016/02/22 18:03:21 UTC
[GitHub] cordova-plugin-wkwebview-engine pull request: The webView should r...
GitHub user dlmma opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5
The webView should reload when a crash occurs
With the iOS9 API, it is now possible to detect when the WKProcess dies. See the API details for reference:
[https://developer.apple.com/library/ios/releasenotes/General/iOS90APIDiffs/Objective-C/WebKit.html]
When it does, the content is blanked out and the URL becomes nil. This results in a "white screen" that can only be resolved by restarting the app. See this for more info: https://bugs.webkit.org/show_bug.cgi?id=148685
I've Implemented the method: `- (void)webViewWebContentProcessDidTerminate:(WKWebView *)webView` which will be called when the process dies and reload the webView.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dlmma/cordova-plugin-wkwebview-engine master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: The webView should r...
Posted by jimmont <gi...@git.apache.org>.
Github user jimmont commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5#issuecomment-194013037
What does it take to get this (very helpful change) merged into master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10817 The webView...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: The webView should r...
Posted by accomplix <gi...@git.apache.org>.
Github user accomplix commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5#issuecomment-187867060
Tested and working ! Thanks, this is a life saver.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #5: CB-10817 The webView should reload...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5
@alexfoxy sorry this issue in JIRA and GH was closed so people might not have noticed it. I think an event is a better idea (whether a new one, or an existing one). Could you file a feature request and set the component to Plugin WKWebviewEngine? issues.cordova.io - thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #5: CB-10817 The webView should reload...
Posted by alexfoxy <gi...@git.apache.org>.
Github user alexfoxy commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5
Do you think it would be possible to show the launch screen when this happens to provide a more seamless experience? For example my app sometimes experiences a crash when you open it from the background resulting in a white screen flashing up for a few seconds. Perhaps we could fire an event via the notification centre when a crash is detected?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: CB-10817 The webView...
Posted by dlmma <gi...@git.apache.org>.
Github user dlmma commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5#issuecomment-194278080
@shazron done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine issue #5: CB-10817 The webView should reload...
Posted by alexfoxy <gi...@git.apache.org>.
Github user alexfoxy commented on the issue:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5
For now I added an event to the notification centre that I observe in the App Delegate which then shows the splash screen. A bit hacky but seems to work well.
I have another issue with WKWebView which I thought you might have some insight on. I have filed a bug report on JIRA (https://issues.apache.org/jira/browse/CB-12408) but no response yet. If you have a minute I'd love to hear if you have any solutions or ideas.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: The webView should r...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/5#issuecomment-194039914
Sorry, overlooked this. The normal process is to file a JIRA issue and reference it in the title here (which will mirror comments to the issue). I've done so: https://issues.apache.org/jira/browse/CB-10817
@dlmma can you prefix CB-10817 to the title of this PR? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org