You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by Chris Hostetter <ho...@fucit.org> on 2009/03/21 03:48:43 UTC

Re: svn commit: r756703 - /lucene/solr/trunk/src/solrj/org/apache/solr/client/solrj/request/RequestWriter.java

: +      OutputStreamWriter writer = new OutputStreamWriter(os, "UTF-8");

Minor nit, but using something like

   public static final Charset UTF_8 = Charset.forName("UTF-8");
      ...
      OutputStreamWriter writer = new OutputStreamWriter(os, UTF_8);

...would be a little cleaner here.  no reason to pay the charset lookup 
cost everytime for a hardcoded constant.



-Hoss


Re: svn commit: r756703 - /lucene/solr/trunk/src/solrj/org/apache/solr/client/solrj/request/RequestWriter.java

Posted by Shalin Shekhar Mangar <sh...@gmail.com>.
On Sat, Mar 21, 2009 at 8:18 AM, Chris Hostetter
<ho...@fucit.org>wrote:

>
> : +      OutputStreamWriter writer = new OutputStreamWriter(os, "UTF-8");
>
> Minor nit, but using something like
>
>   public static final Charset UTF_8 = Charset.forName("UTF-8");
>      ...
>       OutputStreamWriter writer = new OutputStreamWriter(os, UTF_8);
>
> ...would be a little cleaner here.  no reason to pay the charset lookup
> cost everytime for a hardcoded constant.
>

Good point. I'll fix.

-- 
Regards,
Shalin Shekhar Mangar.