You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by jf...@apache.org on 2016/12/21 21:18:27 UTC

[12/24] thrift git commit: THRIFT-3977 PHP extension creates undefined values when deserializing sets Client: PHP Patch: Håkon H. Hitland

THRIFT-3977 PHP extension creates undefined values when deserializing sets
Client: PHP
Patch: H�kon H. Hitland <ha...@likedan.net>

This closes #1133


Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/2a89bd94
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/2a89bd94
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/2a89bd94

Branch: refs/heads/0.10.0
Commit: 2a89bd94ac4ba8c645cad1e0c01606fdac6dc30b
Parents: b7a213c
Author: H�kon H. Hitland <ha...@likedan.net>
Authored: Thu Nov 17 19:37:37 2016 +0100
Committer: Jens Geyer <je...@apache.org>
Committed: Thu Nov 17 21:36:06 2016 +0100

----------------------------------------------------------------------
 lib/php/src/ext/thrift_protocol/php_thrift_protocol7.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/thrift/blob/2a89bd94/lib/php/src/ext/thrift_protocol/php_thrift_protocol7.cpp
----------------------------------------------------------------------
diff --git a/lib/php/src/ext/thrift_protocol/php_thrift_protocol7.cpp b/lib/php/src/ext/thrift_protocol/php_thrift_protocol7.cpp
index d5a2eaf..59fa30a 100644
--- a/lib/php/src/ext/thrift_protocol/php_thrift_protocol7.cpp
+++ b/lib/php/src/ext/thrift_protocol/php_thrift_protocol7.cpp
@@ -626,7 +626,7 @@ void binary_deserialize(int8_t thrift_typeID, PHPInputTransport& transport, zval
 
       for (uint32_t s = 0; s < size; ++s) {
         zval key, value;
-        ZVAL_UNDEF(&value);
+        ZVAL_TRUE(&value);
 
         binary_deserialize(type, transport, &key, elemspec);