You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/23 06:56:24 UTC
[GitHub] [shardingsphere] jiangML opened a new pull request, #23057: Fix the pointcut method parameter configuration does not take effect
jiangML opened a new pull request, #23057:
URL: https://github.com/apache/shardingsphere/pull/23057
Fixes #23056.
Changes proposed in this pull request:
- Fix the pointcut method parameter configuration does not take effect
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #23057: Fix the pointcut parameter configuration does not take effect
Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #23057:
URL: https://github.com/apache/shardingsphere/pull/23057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23057: Fix the pointcut parameter configuration does not take effect
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23057:
URL: https://github.com/apache/shardingsphere/pull/23057#issuecomment-1363695361
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23057?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23057](https://codecov.io/gh/apache/shardingsphere/pull/23057?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dab6ed5) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b7456bf0f6e5e1eee22ced3e17421f4db2a7c325?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b7456bf) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #23057 +/- ##
=========================================
Coverage 50.03% 50.03%
Complexity 2428 2428
=========================================
Files 4110 4110
Lines 57367 57367
Branches 9047 9047
=========================================
+ Hits 28701 28704 +3
+ Misses 26159 26156 -3
Partials 2507 2507
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23057?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...aml/entity/YamlPointcutParameterConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/23057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4veWFtbC9lbnRpdHkvWWFtbFBvaW50Y3V0UGFyYW1ldGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
| [...yaml/swapper/YamlPointcutConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/23057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9wbHVnaW4veWFtbC9zd2FwcGVyL1lhbWxQb2ludGN1dENvbmZpZ3VyYXRpb25Td2FwcGVyLmphdmE=) | `80.00% <100.00%> (ø)` | |
| [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/23057/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `42.85% <0.00%> (+42.85%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org