[GitHub] [pinot] walterddr commented on a diff in pull request #10409: [multistage] Fix Predicate Pushdown by Using Rule Collection

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10409:
URL: https://github.com/apache/pinot/pull/10409#discussion_r1134896651


##########
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotQueryRuleSets.java:
##########
@@ -115,4 +116,12 @@ private PinotQueryRuleSets() {
           PinotAggregateExchangeNodeInsertRule.INSTANCE,
           PinotWindowExchangeNodeInsertRule.INSTANCE
       );
+
+  public static final Collection<RelOptRule> FILTER_PUSHDOWN_RULES = ImmutableList.of(

Review Comment:
   I think for now we should be good. HEP planner is used here to avoid a lengthy volcano planner that adds latency to the planning phase. as long as the plan results are determinisitc we can always change the way we configure the planner IMO



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org