[jira] [Comment Edited] (HIVE-23108) Cleanup HiveBaseResultSet.java

["Peter Vary (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-23108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085823#comment-17085823 ] 

Peter Vary edited comment on HIVE-23108 at 4/17/20, 2:43 PM:
-------------------------------------------------------------

[~belugabehr]: How well these object is covered with tests? The change seems ok, but I would be more comfortable if I could rely on tests instead on my eyes :)
My only minor comment is that I seriously hate {{wasNull}}, and especially how we use it. You see, a getter set the value of the attribute, and then in the next line we rely on this. Either use {{object == null}}, or use {{wasNull()}} if we have to use it :)


was (Author: pvary):
[~belugabehr]: How well these object is covered with tests? The test seems ok, but I would be more comfortable if I could rely on tests instead on my eyes :)
My only minor comment is that I seriously hate {{wasNull}}, and especially how we use it. You see, a getter set the value of the attribute, and then in the next line we rely on this. Either use {{object == null}}, or use {{wasNull()}} if we have to use it :)

> Cleanup HiveBaseResultSet.java
> ------------------------------
>
>                 Key: HIVE-23108
>                 URL: https://issues.apache.org/jira/browse/HIVE-23108
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Minor
>         Attachments: HIVE-23108.1.patch
>
>
> * Unify the code (there are several implementations of the same thing)
>  * Added better error messages
>  * In some cases, the code was throwing RuntimeExceptions which is against the JDBC Spec
>  * Make findColumn a bit more streamlined
>  * Remove non-javadoc comments
>  * Add {{@Override}} annotations where appropriate
>  * Formatting changes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)