You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "LegendPei (via GitHub)" <gi...@apache.org> on 2026/05/31 09:43:42 UTC

[PR] bugfix : Remove vulnerable MySQL Connector/J references from distribution [incubator-seata]

LegendPei opened a new pull request, #8119:
URL: https://github.com/apache/incubator-seata/pull/8119

   <!--
       Licensed to the Apache Software Foundation (ASF) under one or more
       contributor license agreements.  See the NOTICE file distributed with
       this work for additional information regarding copyright ownership.
       The ASF licenses this file to You under the Apache License, Version 2.0
       (the "License"); you may not use this file except in compliance with
       the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
       
       Unless required by applicable law or agreed to in writing, software
       distributed under the License is distributed on an "AS IS" BASIS,
       WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
       See the License for the specific language governing permissions and
       limitations under the License.
   -->
   <!-- Please make sure you have read and understood the contributing guidelines -->
   
   - [ ] I have read the [CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md) guidelines.
   - [ ] I have registered the PR [changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
   
   ### Ⅰ. Describe what this PR did
   This PR removes the vulnerable MySQL Connector/J references from Seata's dependency and distribution packaging configuration.
   
   Main changes:
   - Replace the managed MySQL Connector/J dependency from `mysql:mysql-connector-java` to `com.mysql:mysql-connector-j`.
   - Remove the release/image packaging logic that copied MySQL driver jars into the Seata server distribution.
   - Remove obsolete MySQL driver version properties used only by the removed copy strategy.
   - Update test-scoped MySQL Connector/J usages to the new coordinates.
   - Update affected test imports from legacy MySQL 5 internal classes to MySQL Connector/J 8 classes.
   - Update NOTICE and changelog entries.
   
   This keeps the change scoped to the GHSA/CVE cleanup and aligns with the point that the distributed binary package should not have a hard dependency on the MySQL driver.
   
   
   ### Ⅱ. Does this pull request fix one issue?
   <!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
   fixes #8101
   
   ### Ⅲ. Why don't you add test cases (unit test/integration test)? 
   
   No new unit or integration test is added because this PR mainly removes packaging-time dependency copying and updates dependency coordinates. The behavioral code path is unchanged.
   
   Existing test compilation was updated where the MySQL Connector/J upgrade exposed references to legacy MySQL 5 internal classes.
   
   
   ### Ⅳ. Describe how to verify it
   
   
   ### Ⅴ. Special notes for reviews
   
   The remaining mysql-connector-java matches are only historical changelog entries. Existing com.mysql.jdbc.Driver string defaults are kept for compatibility and are not bundled driver dependencies.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] bugfix : Remove vulnerable MySQL Connector/J references from distribution [incubator-seata]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8119:
URL: https://github.com/apache/incubator-seata/pull/8119#issuecomment-4586464386

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/8119?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 72.57%. Comparing base ([`da65f1e`](https://app.codecov.io/gh/apache/incubator-seata/commit/da65f1e06dfd8d26a5d03948bdfd56dab2bdc646?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`90ee9e9`](https://app.codecov.io/gh/apache/incubator-seata/commit/90ee9e94577ca7e540515c6c09d79454075dc59d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##                2.x    #8119      +/-   ##
   ============================================
   - Coverage     72.66%   72.57%   -0.10%     
     Complexity      883      883              
   ============================================
     Files          1327     1327              
     Lines         50714    50714              
     Branches       6049     6049              
   ============================================
   - Hits          36851    36805      -46     
   - Misses        10848    10895      +47     
   + Partials       3015     3014       -1     
   ```
   [see 9 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/8119/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/incubator-seata/pull/8119/graphs/tree.svg?width=650&height=150&src=pr&token=tbmHt2ZfxO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/incubator-seata/pull/8119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org