[GitHub] [cloudstack] ravening commented on a change in pull request #4666: Fix bug in creating shared network

[GitBox <gi...@apache.org>]

ravening commented on a change in pull request #4666:
URL: https://github.com/apache/cloudstack/pull/4666#discussion_r572723655



##########
File path: ui/src/views/network/CreateSharedNetworkForm.vue
##########
@@ -628,6 +628,14 @@ export default {
         }
       }
     },
+    fetchFormPhysicalNetworkData () {
+      this.fetchPhysicalNetworkData()
+
+      // Wait until the data is fetched else it will result in NPE
+      while (this.formSelectedPhysicalNetwork === undefined ||
+            this.formSelectedPhysicalNetwork === null) {
+      }

Review comment:
       @shwstppr actually the api `listPhysicalNetworks` never gets called and hence the value `this.formSelectedPhysicalNetwork` is not populated . Typically there should be atleast 1 physical network. so i dont much of an issue here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org