You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "ganczarek (via GitHub)" <gi...@apache.org> on 2023/08/30 11:18:35 UTC
[GitHub] [superset] ganczarek opened a new issue, #25123: Export zip files are not compressed
ganczarek opened a new issue, #25123:
URL: https://github.com/apache/superset/issues/25123
[Superset uses](https://github.com/search?q=repo%3Aapache%2Fsuperset+language%3Apython+%2Fwith+ZipFile%28.*%22w%22%29%2F+AND+NOT+path%3Atest&type=code) default ZipFile compression, which is [ZIP_STORED](https://docs.python.org/3/library/zipfile.html#zipfile.ZipFile). Hence, exported assets are not compressed. I suspect it's not intentional or at least should be configurable.
#### How to reproduce the bug
Export all assets with `/api/v1/assets/export/` endpoint. Other export endpoints - like `/api/v1/dashboard/export/` - also don't compress results.
### Expected results
Result zip file is compressed.
### Actual results
Result zip file is not compressed.
### Environment
- browser type and version: n/a
- superset version: `2.1.0`
- python version: `3.8.13`
- node.js version: n/a
- any feature flags active: `VERSIONED_EXPORT: True` (enabled by deafult)
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Export zip files are not compressed [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #25123: Export zip files are not compressed
URL: https://github.com/apache/superset/issues/25123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Export zip files are not compressed [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #25123:
URL: https://github.com/apache/superset/issues/25123#issuecomment-1989183751
Interesting find. CC @betodealmeida in case there are feelings/complications around this.
I suspect that the non-compressed ZIP isn't causing an issue for most people (the files are small), and everything _works_, so this is not a bug. I'll move it to a discussion.
I think the main reason NOT to compress things is that it would add another dependency for the compression module... and I'm not sure if people have feelings about which is best.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org