You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by GitBox <gi...@apache.org> on 2022/11/22 11:02:38 UTC
[GitHub] [streampipes] vesense opened a new pull request, #151: STREAMPIPES-644: Upgrade Flink version to latest 1.16
vesense opened a new pull request, #151:
URL: https://github.com/apache/streampipes/pull/151
<!--
~ Licensed to the Apache Software Foundation (ASF) under one or more
~ contributor license agreements. See the NOTICE file distributed with
~ this work for additional information regarding copyright ownership.
~ The ASF licenses this file to You under the Apache License, Version 2.0
~ (the "License"); you may not use this file except in compliance with
~ the License. You may obtain a copy of the License at
~
~ http://www.apache.org/licenses/LICENSE-2.0
~
~ Unless required by applicable law or agreed to in writing, software
~ distributed under the License is distributed on an "AS IS" BASIS,
~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
~ See the License for the specific language governing permissions and
~ limitations under the License.
~
-->
<!--
Thanks for contributing! Here are some tips you can follow to help us incorporate your contribution quickly and easily:
1. If this is your first time, please read our contributor guidelines:
- https://streampipes.apache.org/getinvolved.html
- https://cwiki.apache.org/confluence/display/STREAMPIPES/Getting+Started
2. Make sure the PR title is formatted like: `[STREAMPIPES-<Jira issue #>] PR title ...`
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., `[WIP][STREAMPIPES-<Jira issue #>] PR title ...`.
4. Please write your PR title to summarize what this PR proposes/fixes.
5. Be sure to keep the PR description updated to reflect all changes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. Make sure tests pass via `mvn clean install`.
8. (Optional) If the contribution is large, please file an Apache ICLA
- http://apache.org/licenses/icla.pdf
-->
### Purpose
<!--
Please clarify what changes you are proposing and describe how those changes will address the issue.
-->
Upgrade Flink version to latest 1.16
### Approach
<!--
Describe how you are implementing the solutions along with the design details.
-->
### Samples
<!--
Provide high-level details about the samples related to this feature.
-->
### Remarks
<!--
List related issues/PRs, link to discussions in the mailing list, todo items, or any other notes related to the PR.
-->
Fixes: <Jira issue link>
https://issues.apache.org/jira/browse/STREAMPIPES-644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on pull request #151: STREAMPIPES-644: Upgrade Flink version to latest 1.16
Posted by GitBox <gi...@apache.org>.
bossenti commented on PR #151:
URL: https://github.com/apache/streampipes/pull/151#issuecomment-1371347788
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] STREAMPIPES-644: Upgrade Flink version to latest 1.16 (streampipes)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #151:
URL: https://github.com/apache/streampipes/pull/151#issuecomment-1526062963
Hello there :wave:<br> <br> We noticed that it's been some time since activity occurred on your pull request :thinking:. In order to keep things moving forward, we're marking this PR as _stale_ and giving you 7 days to respond before it's automatically closed :alarm_clock:.<br> <br> Please take a moment to review your pull request and make any necessary updates or changes :man_technologist:. If you need more time or have any questions, please don't hesitate to let us know :speech_balloon:.<br> <br> Thank you for your contributions to our project, and we look forward to hearing back from you soon :pray:.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] STREAMPIPES-644: Upgrade Flink version to latest 1.16 (streampipes)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #151:
URL: https://github.com/apache/streampipes/pull/151#issuecomment-1535589188
Hello there :wave:<br> <br> Unfortunately, we didn't hear back from you regarding your pull request, so we're closing it now. Don't worry, you can always reopen the PR at any time if you wish to continue working on it :raised_hands:.<br> <br> Please note that the branch associated with this pull request will not be deleted, so you can still access your changes and continue to work on them as needed :computer:.<br> <br> Thank you for your contributions to our project, and we hope to see you again soon!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] STREAMPIPES-644: Upgrade Flink version to latest 1.16 (streampipes)
Posted by "vesense (via GitHub)" <gi...@apache.org>.
vesense commented on PR #151:
URL: https://github.com/apache/streampipes/pull/151#issuecomment-1408520625
@tenthe Thanks for your feedback, let me have a deep check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] STREAMPIPES-644: Upgrade Flink version to latest 1.16 (streampipes)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #151: STREAMPIPES-644: Upgrade Flink version to latest 1.16
URL: https://github.com/apache/streampipes/pull/151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] tenthe commented on pull request #151: STREAMPIPES-644: Upgrade Flink version to latest 1.16
Posted by GitBox <gi...@apache.org>.
tenthe commented on PR #151:
URL: https://github.com/apache/streampipes/pull/151#issuecomment-1369551308
@bossenti I removed `flinkspector` in #1027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] vesense commented on pull request #151: STREAMPIPES-644: Upgrade Flink version to latest 1.16
Posted by GitBox <gi...@apache.org>.
vesense commented on PR #151:
URL: https://github.com/apache/streampipes/pull/151#issuecomment-1374712523
Sorry for the delay response. Thanks @tenthe for your update https://github.com/apache/streampipes/pull/1027.
I merged the https://github.com/apache/streampipes/pull/1027 into flink_1.16, the error was the same as in the before.
I checked the build logs*(1) and found the reason: When build `streampipes-processors-aggregation-flink`, maven uses the pom*(2) from remote apache central repo not local. That is to say, the remote pom is not the latest version.
Maybe this is a bug, @tenthe @bossenti Could you take a look?
*1:
https://github.com/apache/streampipes/actions/runs/3865100468/jobs/6588382054#step:4:76696
key part:
>[INFO] --- maven-remote-resources-plugin:1.7.0:process (process-resource-bundles) @ streampipes-processors-aggregation-flink ---
[INFO] Preparing remote bundle org.apache:apache-jar-resource-bundle:1.4
[INFO] Copying 3 resources from 1 bundle.
Downloading from apache.snapshots: https://repository.apache.org/snapshots/org/apache/streampipes/streampipes-wrapper-flink/0.91.0-SNAPSHOT/streampipes-wrapper-flink-0.91.0-20230107.223648-27.pom
*2:
https://repository.apache.org/snapshots/org/apache/streampipes/streampipes-wrapper-flink/0.91.0-SNAPSHOT/streampipes-wrapper-flink-0.91.0-20230107.223648-27.pom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on pull request #151: STREAMPIPES-644: Upgrade Flink version to latest 1.16
Posted by GitBox <gi...@apache.org>.
bossenti commented on PR #151:
URL: https://github.com/apache/streampipes/pull/151#issuecomment-1336210391
@vesense could you please have a look on the failed build?
https://github.com/apache/streampipes/actions/runs/3522766888/jobs/5906126439#step:4:91323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] tenthe commented on pull request #151: STREAMPIPES-644: Upgrade Flink version to latest 1.16
Posted by GitBox <gi...@apache.org>.
tenthe commented on PR #151:
URL: https://github.com/apache/streampipes/pull/151#issuecomment-1377057368
Hi @vesense,
I tried to resolve the issues locally, but I've ran into similar problems.
I suspect that the problem is with the Flink version update, some of the other dependencies related to Flink also need to be changed. We should check them one by one to see if they are still required for this Flink version or if there are alternatives that need to be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] vesense commented on pull request #151: STREAMPIPES-644: Upgrade Flink version to latest 1.16
Posted by GitBox <gi...@apache.org>.
vesense commented on PR #151:
URL: https://github.com/apache/streampipes/pull/151#issuecomment-1338614667
@bossenti Thanks for reminding. It is successfully to build in my local environment. I'll check it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on pull request #151: STREAMPIPES-644: Upgrade Flink version to latest 1.16
Posted by GitBox <gi...@apache.org>.
bossenti commented on PR #151:
URL: https://github.com/apache/streampipes/pull/151#issuecomment-1367377727
I'm afraid that this upgrade is not possible due to our usage of `flinkspector` for unit tests.
Flinkspector only supports flink <= 1.14 (if I'm not mistaken) and hasn't published a release since 2019.
So we probably need to look for an alternative, any ideas @tenthe @dominikriemer @vesense @RobertIndie?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on pull request #151: STREAMPIPES-644: Upgrade Flink version to latest 1.16
Posted by GitBox <gi...@apache.org>.
bossenti commented on PR #151:
URL: https://github.com/apache/streampipes/pull/151#issuecomment-1369646647
@tenthe thanks, then we can update this PR and merge it I guess
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org