You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by egorklimov <gi...@git.apache.org> on 2018/07/04 14:57:18 UTC
[GitHub] zeppelin pull request #3053: [ZEPPELIN-3583] Add function getNoteName() in I...
GitHub user egorklimov opened a pull request:
https://github.com/apache/zeppelin/pull/3053
[ZEPPELIN-3583] Add function getNoteName() in InterpreterContext
### What is this PR for?
Now we could get only current user and note ID.
```
note_id = z.getInterpreterContext().getNoteId()
user = z.getInterpreterContext().getAuthenticationInfo().getUser()
```
It would be nice if we could also get note name, like:
```
note_name = z.getInterpreterContext().getNoteName()
```
### What type of PR is it?
Improvement
### What is the Jira issue?
issue on Jira: https://issues.apache.org/jira/browse/ZEPPELIN-3583
### How should this be tested?
* CI pass
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3583
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3053.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3053
----
commit 23aa5138c1def8f10a3fe2712040cacfd3466595
Author: egorklimov <kl...@...>
Date: 2018-07-04T13:09:22Z
Add noteName
----
---
[GitHub] zeppelin pull request #3053: [ZEPPELIN-3583] Add function getNoteName() in I...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3053
---
[GitHub] zeppelin pull request #3053: [WIP] [ZEPPELIN-3583] Add function getNoteName(...
Posted by egorklimov <gi...@git.apache.org>.
GitHub user egorklimov reopened a pull request:
https://github.com/apache/zeppelin/pull/3053
[WIP] [ZEPPELIN-3583] Add function getNoteName() in InterpreterContext
### What is this PR for?
Now we could get only current user and note ID.
```
note_id = z.getInterpreterContext().getNoteId()
user = z.getInterpreterContext().getAuthenticationInfo().getUser()
```
It would be nice if we could also get note name, like:
```
note_name = z.getInterpreterContext().getNoteName()
```
### What type of PR is it?
Improvement
### What is the Jira issue?
issue on Jira: https://issues.apache.org/jira/browse/ZEPPELIN-3583
### How should this be tested?
* CI pass
### Screenshots
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-3583
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3053.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3053
----
commit 23aa5138c1def8f10a3fe2712040cacfd3466595
Author: egorklimov <kl...@...>
Date: 2018-07-04T13:09:22Z
Add noteName
commit bce37da3cccf90f7a179552999b824a9a0631461
Author: egorklimov <kl...@...>
Date: 2018-07-05T13:49:38Z
Builder fixed
----
---
[GitHub] zeppelin issue #3053: [ZEPPELIN-3583] Add function getNoteName() in Interpre...
Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov commented on the issue:
https://github.com/apache/zeppelin/pull/3053
Look again please:
* Thrift file updated
* CI is green: https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/400831400
---
[GitHub] zeppelin pull request #3053: [WIP] [ZEPPELIN-3583] Add function getNoteName(...
Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov closed the pull request at:
https://github.com/apache/zeppelin/pull/3053
---
[GitHub] zeppelin issue #3053: WIP [ZEPPELIN-3583] Add function getNoteName() in Inte...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3053
@egorklimov Have you tried it in zeppelin ? It doesn't seem correct to me. Because you didn't pass note name from zeppelin server to interpreter process. It would always be null if you call `z.getInterpreterContext().getNoteName()`
---
[GitHub] zeppelin issue #3053: [ZEPPELIN-3583] Add function getNoteName() in Interpre...
Posted by egorklimov <gi...@git.apache.org>.
Github user egorklimov commented on the issue:
https://github.com/apache/zeppelin/pull/3053
Looks like fixed
* CI is green: https://travis-ci.org/TinkoffCreditSystems/zeppelin/builds/400447972
* Screenshot added.
---