[jira] Resolved: (ADFFACES-335) generated css file has errors as a result of empty styleclass removal optimization

["Adam Winer (JIRA)" <ad...@incubator.apache.org>]

     [ http://issues.apache.org/jira/browse/ADFFACES-335?page=all ]

Adam Winer resolved ADFFACES-335.
---------------------------------

    Resolution: Fixed

Fixed.  The algorithm for identifying empty styles didn't account for styles where the plain selector showed up after all the compound selectors.

> generated css file has errors as a result of empty styleclass removal optimization
> ----------------------------------------------------------------------------------
>
>                 Key: ADFFACES-335
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-335
>             Project: MyFaces ADF-Faces
>          Issue Type: Bug
>          Components: Skinning
>            Reporter: Jeanne Waldman
>         Assigned To: Adam Winer
>
> If you have this in your skin file:
> /* This is a legal and standard in our css files short-hand for af|foo:fatal af|foo::input-chooser-wrapper */
> af|foo:fatal::input-chooser-wrapper {
>     color: red;
> }
> af|foo::input-chooser-wrapper {
> }
> The generated css file generates this problem style definition:
> .af_foo.p_AFFatal .af_foo_input-chooser-wrapper,.xcx.p_AFFatal . {border:1px #ff3333 solid}
> Notice that .af_foo_input-chooser-wrapper gets shortened to the empty string.
> This causes the browser to get confused, and strange 'skinning' bugs appear.
> Now, comment out the af|foo::input-chooser-wrapper, and things work ok.
> Somewhere the code is seeing the empty styleclass and removing it, although it shouldn't be.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira