You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/12/23 05:38:40 UTC
[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4768:
Update kamon-core, instrumentations and reporters to 2.0.x.
chetanmeh commented on a change in pull request #4768: Update kamon-core, instrumentations and reporters to 2.0.x.
URL: https://github.com/apache/openwhisk/pull/4768#discussion_r360771420
##########
File path: core/controller/src/main/scala/org/apache/openwhisk/core/controller/Controller.scala
##########
@@ -215,12 +215,12 @@ object Controller {
def start(args: Array[String])(implicit actorSystem: ActorSystem, logger: Logging): Unit = {
ConfigMXBean.register()
- Kamon.loadReportersFromConfig()
+ Kamon.init()
Review comment:
For some reason with standalone atleast when I access http://localhost:3233/metrics then I do not see prometheus metrics being dumped. The output is empty. Upon debugging I see metrics being sent to reporter but for some reason accumulator does not retain them. Not sure if its a bug in Kamon side
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services