[GitHub] reddycharan commented on a change in pull request #905: ISSUE #904: short hostname for bookieid

[GitBox <gi...@apache.org>]

reddycharan commented on a change in pull request #905: ISSUE #904: short hostname for bookieid
URL: https://github.com/apache/bookkeeper/pull/905#discussion_r158390100
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/BookieShell.java
 ##########
 @@ -1244,8 +1244,6 @@ Options getOptions() {
             super(CMD_LISTBOOKIES);
             opts.addOption("rw", "readwrite", false, "Print readwrite bookies");
             opts.addOption("ro", "readonly", false, "Print readonly bookies");
-            opts.addOption("h", "hostnames", false,
 
 Review comment:
   ok..I'll add it back but it will effectively be ignored. BTW I dont see any particular format for adding deprecated tag for command line option. I'll just add following comment for the 'hostnames' option -
   
   "//@deprecated 'rw'/'ro' option prints both hostname and ip, so this option is not needed anymore"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services