[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #158: [Improvement] Introduce a new class ShuffleTaskInfo

[GitBox <gi...@apache.org>]

smallzhongfeng commented on code in PR #158:
URL: https://github.com/apache/incubator-uniffle/pull/158#discussion_r945584957


##########
server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java:
##########
@@ -250,11 +242,8 @@ public void updateCachedBlockIds(String appId, int shuffleId, ShufflePartitioned
   }
 
   public Roaring64NavigableMap getCachedBlockIds(String appId, int shuffleId) {
-    Map<Integer, Roaring64NavigableMap> shuffleIdToBlockIds = cachedBlockIds.get(appId);
-    if (shuffleIdToBlockIds == null) {
-      LOG.warn("Unexpected value when getCachedBlockIds for appId[" + appId + "]");
-      return Roaring64NavigableMap.bitmapOf();
-    }
+    Map<Integer, Roaring64NavigableMap> shuffleIdToBlockIds = shuffleTaskInfo

Review Comment:
   `shuffleIdToBlockIds` was initialized in `shuffleTaskInfo`, it is not a null value and only possible to have an empty map. I think there should be no logs here. WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org