You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "oleg-vlsk (via GitHub)" <gi...@apache.org> on 2024/05/21 02:32:58 UTC
[PR] IGNITE-22216 GridCacheQueryInfo#all and GridCacheQueryRequest#all removed [ignite]
oleg-vlsk opened a new pull request, #11356:
URL: https://github.com/apache/ignite/pull/11356
…oved
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-22216 GridCacheQueryInfo#all and GridCacheQueryRequest#all removed [ignite]
Posted by "oleg-vlsk (via GitHub)" <gi...@apache.org>.
oleg-vlsk commented on code in PR #11356:
URL: https://github.com/apache/ignite/pull/11356#discussion_r1666436115
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java:
##########
@@ -1349,13 +1349,7 @@ protected void runQuery(GridCacheQueryInfo qryInfo) {
if (!finished)
rmvIter = false;
- if (!qryInfo.allPages())
- return;
-
- data = new ArrayList<>(pageSize);
-
- if (stop)
Review Comment:
The `stop` variable is removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-22216 GridCacheQueryInfo#all and GridCacheQueryRequest#all removed [ignite]
Posted by "oleg-vlsk (via GitHub)" <gi...@apache.org>.
oleg-vlsk commented on code in PR #11356:
URL: https://github.com/apache/ignite/pull/11356#discussion_r1666435654
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java:
##########
@@ -1349,13 +1349,7 @@ protected void runQuery(GridCacheQueryInfo qryInfo) {
if (!finished)
rmvIter = false;
- if (!qryInfo.allPages())
- return;
-
- data = new ArrayList<>(pageSize);
-
- if (stop)
- break; // while
Review Comment:
`PageSent` removed from this block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-22216 GridCacheQueryInfo#all and GridCacheQueryRequest#all removed [ignite]
Posted by "timoninmaxim (via GitHub)" <gi...@apache.org>.
timoninmaxim merged PR #11356:
URL: https://github.com/apache/ignite/pull/11356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-22216 GridCacheQueryInfo#all and GridCacheQueryRequest#all removed [ignite]
Posted by "timoninmaxim (via GitHub)" <gi...@apache.org>.
timoninmaxim commented on code in PR #11356:
URL: https://github.com/apache/ignite/pull/11356#discussion_r1663921433
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java:
##########
@@ -1349,13 +1349,7 @@ protected void runQuery(GridCacheQueryInfo qryInfo) {
if (!finished)
rmvIter = false;
- if (!qryInfo.allPages())
- return;
-
- data = new ArrayList<>(pageSize);
-
- if (stop)
Review Comment:
Now `stop` is useless variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-22216 GridCacheQueryInfo#all and GridCacheQueryRequest#all removed [ignite]
Posted by "timoninmaxim (via GitHub)" <gi...@apache.org>.
timoninmaxim commented on code in PR #11356:
URL: https://github.com/apache/ignite/pull/11356#discussion_r1663919894
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/GridCacheQueryManager.java:
##########
@@ -1349,13 +1349,7 @@ protected void runQuery(GridCacheQueryInfo qryInfo) {
if (!finished)
rmvIter = false;
- if (!qryInfo.allPages())
- return;
-
- data = new ArrayList<>(pageSize);
-
- if (stop)
- break; // while
Review Comment:
Setting `pageSent` in this block now useless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org