[Bug 53796] New: TestCompiler uses static Set which can grow huge

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53796

          Priority: P2
            Bug ID: 53796
          Assignee: issues@jmeter.apache.org
           Summary: TestCompiler uses static Set which can grow huge
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: sebb@apache.org
          Hardware: All
            Status: NEW
           Version: unspecified
         Component: Main
           Product: JMeter

The TestCompiler uses a static Set (PAIRING) which can grow very large if there
are lots of threads. This limits the total number of thread groups, even when
using delayed start.

The Set is used to prevent a child being added to the same parent twice.

One possible solution is to save the information in the parent instance, rather
than a static set. At the end of a thread, the parent instance will no longer
be needed, and the memory can be reclaimed. [If there is still a reference to
either parent or child, the memory won't be released, but that applies to the
current implementation also.]

It's not clear whether there can ever be a duplicate ObjectPair, as most test
elements are cloned. But in case duplicates are possible, something like the
above solution is necessary.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 53796] TestCompiler uses static Set which can grow huge

[bu...@apache.org]

https://issues.apache.org/bugzilla/show_bug.cgi?id=53796

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Sebb <se...@apache.org> ---
Fixed as per description:

URL: http://svn.apache.org/viewvc?rev=1378780&view=rev
Log:
TestCompiler uses static Set which can grow huge
Bugzilla Id: 53796

Added:
    jmeter/trunk/src/core/org/apache/jmeter/threads/TestCompilerHelper.java  
(with props)
Modified:
    jmeter/trunk/src/core/org/apache/jmeter/control/GenericController.java
    jmeter/trunk/src/core/org/apache/jmeter/threads/AbstractThreadGroup.java
    jmeter/trunk/src/core/org/apache/jmeter/threads/TestCompiler.java
    jmeter/trunk/xdocs/changes.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.