You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/08/11 00:08:11 UTC

[GitHub] [incubator-nuttx] patacongo commented on pull request #1554: Add support for hard links to CROMFS

patacongo commented on pull request #1554:
URL: https://github.com/apache/incubator-nuttx/pull/1554#issuecomment-671650383


   @davids5 I worked a long day and got the basic implementation in place in one (long) day.  It involved more code changes that I expected from implementing the same feature in ROMFS.  The main complexity increase is that ROMFS uses a block driver, but CROMFS accesses the FS image directly in ROM.  That should perform better, but it means that I can not read a hard link directory entry and modify it so that it has the same properties as the link target entry.  Rather, I had to add additional writable data structures and more complexity than I anticipated.
   
   Could you help with verification and merge (when we are absolutely confident that all is in order).  My testing is light and PX4 has a vested interest in getting this done right and quickly.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org