You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "voidmatcha (via GitHub)" <gi...@apache.org> on 2026/10/15 15:22:20 UTC

[PR] [ZEPPELIN-6738] Disable Ant Design motion in React surfaces [zeppelin]

voidmatcha opened a new pull request, #5573:
URL: https://github.com/apache/zeppelin/pull/5573

   ### What is this PR for?
   
   Follow up on #5558 by simplifying how the React remote handles theme motion. The current implementation adds a document-wide class during a theme change and removes it after two animation frames. This PR removes that class, timer, and CSS rule, and uses Ant Design's `motion: false` token instead.
   
   This disables Ant Design motion across React surfaces, in line with the Angular UI's existing transition reset. Custom Assistant panel transitions remain unchanged.
   
   ### What type of PR is it?
   
   Improvement
   
   ### Todos
   
   * [ ] Check theme switching and Ant Design overlays in a live notebook.
   
   ### What is the Jira issue?
   
   ZEPPELIN-6738
   
   ### How should this be tested?
   
   From `zeppelin-web-angular/projects/zeppelin-react/`:
   
   ```bash
   npm test
   npm run typecheck
   npm run build
   ```
   
   The full React suite passed (125 tests), as did the typecheck, production build, and ESLint on the changed files. The live notebook check remains open.
   
   ### Screenshots (if appropriate)
   
   N/A
   
   ### Questions:
   
   * Does the license files need to update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6738] Disable Ant Design motion in React surfaces [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5573:
URL: https://github.com/apache/zeppelin/pull/5573#issuecomment-6220940336

   Merged into master (f3483585).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6738] Disable Ant Design motion in React surfaces [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee merged PR #5573:
URL: https://github.com/apache/zeppelin/pull/5573


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org