You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2022/02/14 11:31:51 UTC
[GitHub] [hbase] virajjasani commented on a change in pull request #4095: HBASE-26730 Extend hbase shell 'status' command to support an option 'tasks'
virajjasani commented on a change in pull request #4095:
URL: https://github.com/apache/hbase/pull/4095#discussion_r805750187
##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -923,15 +923,18 @@ def status(format, type)
for v in cluster_metrics.getRegionStatesInTransition
puts(format(' %s', v))
end
- master = cluster_metrics.getMasterName
- puts(format('active master: %s:%d %d', master.getHostname, master.getPort,
- master.getStartcode))
- puts(format('%d backup masters', cluster_metrics.getBackupMasterNames.size))
- for server in cluster_metrics.getBackupMasterNames
+ master = cluster_metrics.getMaster
+ unless master.nil?
+ puts(format('active master: %s:%d %d', master.getHostname, master.getPort, master.getStartcode))
+ for task in cluster_metrics.getMasterTasks
+ puts(format(' %s', task.toString))
+ end
+ end
+ puts(format('%d backup masters', cluster_metrics.getBackupMastersSize))
+ for server in cluster_metrics.getBackupMasters
puts(format(' %s:%d %d', server.getHostname, server.getPort, server.getStartcode))
end
-
- master_coprocs = @admin.getMasterCoprocessorNames.toString
+ master_coprocs = java.util.Arrays.toString(@admin.getMasterCoprocessors)
Review comment:
This seems additional change, is it for better readability or it's just a mechanical change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org