You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Akihiro Matsukawa (JIRA)" <ji...@apache.org> on 2014/03/26 21:50:17 UTC

[jira] [Updated] (PIG-3836) Pig signature has has guava version dependency

     [ https://issues.apache.org/jira/browse/PIG-3836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Akihiro Matsukawa updated PIG-3836:
-----------------------------------

    Attachment: 0001-use-murmur-hash-with-0-seed.patch

Attached patch directly uses a murmur hash seeded with 0 to remove this version dependency on guava.

> Pig signature has has guava version dependency
> ----------------------------------------------
>
>                 Key: PIG-3836
>                 URL: https://issues.apache.org/jira/browse/PIG-3836
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Akihiro Matsukawa
>            Assignee: Akihiro Matsukawa
>         Attachments: 0001-use-murmur-hash-with-0-seed.patch
>
>
> We currently use Hashing.goodFastHash(32) to generate signatures for the logical plan. Under the hood, this is a murmur32 hash.
> Guava 11, which pig directly depends on, always seeds the hash with 0.
> http://docs.guava-libraries.googlecode.com/git-history/v11.0/javadoc/src-html/com/google/common/hash/Hashing.html#line.85
> In future versions of Guava, it is seeded by current time: http://docs.guava-libraries.googlecode.com/git-history/v14.0/javadoc/src-html/com/google/common/hash/Hashing.html#line.47
> So when future versions of guava is pulled into the classpath (which if often), we no longer get the same signature for the same logical plan. This introduces unnecessary complexity for managing the classpath.



--
This message was sent by Atlassian JIRA
(v6.2#6252)