You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "github-actions[bot] (via GitHub)" <gi...@apache.org> on 2023/06/19 17:30:11 UTC
[GitHub] [doris] github-actions[bot] commented on pull request #21003: Add hdfs benchmark tool
github-actions[bot] commented on PR #21003:
URL: https://github.com/apache/doris/pull/21003#issuecomment-1597525745
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/5314668682") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In bin/run-fs-benchmark.sh line 267:
${LIMIT:+${LIMIT}} ${DORIS_HOME}/lib/fs_benchmark_tool "$@" 2>&1 | tee "${LOG_DIR}/fs_benchmark_test.log"
^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
${LIMIT:+${LIMIT}} "${DORIS_HOME}"/lib/fs_benchmark_tool "$@" 2>&1 | tee "${LOG_DIR}/fs_benchmark_test.log"
In bin/run-fs-benchmark.sh line 268:
file_size=`cat ${LOG_DIR}/fs_benchmark_test.log | grep "size" | awk 'NR==1{print $NF}'`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
file_size=$(cat "${LOG_DIR}"/fs_benchmark_test.log | grep "size" | awk 'NR==1{print $NF}')
In bin/run-fs-benchmark.sh line 269:
thread_num=`cat ${LOG_DIR}/fs_benchmark_test.log | grep "threads = " | awk 'NR==1{print $NF}'`
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
thread_num=$(cat "${LOG_DIR}"/fs_benchmark_test.log | grep "threads = " | awk 'NR==1{print $NF}')
In bin/run-fs-benchmark.sh line 270:
if [[ ! "$file_size" =~ ^[0-9]+$ ]];then
^--------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
if [[ ! "${file_size}" =~ ^[0-9]+$ ]];then
In bin/run-fs-benchmark.sh line 273:
eval `cat ${LOG_DIR}/fs_benchmark_test.log | grep _median | awk '{printf("qps=%sMB/s,\nlatency=%sms", "'$file_size'"/ 1024 / 1024 / ($2 * "'$thread_num'" / 1000), $2 * "'$thread_num'")}'`
^-- SC2046 (warning): Quote this to prevent word splitting.
^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^--------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^---------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
eval $(cat "${LOG_DIR}"/fs_benchmark_test.log | grep _median | awk '{printf("qps=%sMB/s,\nlatency=%sms", "'"${file_size}"'"/ 1024 / 1024 / ($2 * "'"${thread_num}"'" / 1000), $2 * "'"${thread_num}"'")}')
In bin/run-fs-benchmark.sh line 278:
echo "thread_num: $thread_num."
^---------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
echo "thread_num: ${thread_num}."
In bin/run-fs-benchmark.sh line 279:
echo "qps: $qps."
^--^ SC2154 (warning): qps is referenced but not assigned.
^--^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
echo "qps: ${qps}."
In bin/run-fs-benchmark.sh line 280:
echo "latency: $latency."
^------^ SC2154 (warning): latency is referenced but not assigned.
^------^ SC2250 (style): Prefer putting braces around variable references even when not strictly required.
Did you mean:
echo "latency: ${latency}."
For more information:
https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
https://www.shellcheck.net/wiki/SC2154 -- latency is referenced but not ass...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- bin/run-fs-benchmark.sh.orig
+++ bin/run-fs-benchmark.sh
@@ -265,12 +265,12 @@
export JEMALLOC_CONF="percpu_arena:percpu,background_thread:true,metadata_thp:auto,muzzy_decay_ms:30000,dirty_decay_ms:30000,oversize_threshold:0,lg_tcache_max:16,prof_prefix:jeprof.out"
${LIMIT:+${LIMIT}} ${DORIS_HOME}/lib/fs_benchmark_tool "$@" 2>&1 | tee "${LOG_DIR}/fs_benchmark_test.log"
-file_size=`cat ${LOG_DIR}/fs_benchmark_test.log | grep "size" | awk 'NR==1{print $NF}'`
-thread_num=`cat ${LOG_DIR}/fs_benchmark_test.log | grep "threads = " | awk 'NR==1{print $NF}'`
-if [[ ! "$file_size" =~ ^[0-9]+$ ]];then
- file_size=1;
+file_size=$(cat ${LOG_DIR}/fs_benchmark_test.log | grep "size" | awk 'NR==1{print $NF}')
+thread_num=$(cat ${LOG_DIR}/fs_benchmark_test.log | grep "threads = " | awk 'NR==1{print $NF}')
+if [[ ! "$file_size" =~ ^[0-9]+$ ]]; then
+ file_size=1
fi
-eval `cat ${LOG_DIR}/fs_benchmark_test.log | grep _median | awk '{printf("qps=%sMB/s,\nlatency=%sms", "'$file_size'"/ 1024 / 1024 / ($2 * "'$thread_num'" / 1000), $2 * "'$thread_num'")}'`
+eval $(cat ${LOG_DIR}/fs_benchmark_test.log | grep _median | awk '{printf("qps=%sMB/s,\nlatency=%sms", "'$file_size'"/ 1024 / 1024 / ($2 * "'$thread_num'" / 1000), $2 * "'$thread_num'")}')
echo "------------------------------"
echo " Benchmark Result "
@@ -278,4 +278,3 @@
echo "thread_num: $thread_num."
echo "qps: $qps."
echo "latency: $latency."
-
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org