You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/06/04 15:55:22 UTC

[GitHub] [dubbo-go] williamfeng323 opened a new pull request #586: Feature/filter comment optimise

williamfeng323 opened a new pull request #586:
URL: https://github.com/apache/dubbo-go/pull/586


   **What this PR does**:
   Added comments to filter directory
   
   **Which issue(s) this PR fixes**:
   Fixes #569
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] zouyx merged pull request #586: Mod: update the comments in filter directory

Posted by GitBox <gi...@apache.org>.
zouyx merged pull request #586:
URL: https://github.com/apache/dubbo-go/pull/586


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #586: Mod: update the comments in filter directory

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #586:
URL: https://github.com/apache/dubbo-go/pull/586#issuecomment-638963451


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=h1) Report
   > Merging [#586](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **increase** coverage by `0.25%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/586/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #586      +/-   ##
   ===========================================
   + Coverage    66.43%   66.68%   +0.25%     
   ===========================================
     Files          184      185       +1     
     Lines         9712     9749      +37     
   ===========================================
   + Hits          6452     6501      +49     
   + Misses        2620     2611       -9     
   + Partials       640      637       -3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <ø> (ø)` | |
   | [filter/filter\_impl/active\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2FjdGl2ZV9maWx0ZXIuZ28=) | `66.66% <ø> (ø)` | |
   | [filter/filter\_impl/auth/accesskey\_storage.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvYWNjZXNza2V5X3N0b3JhZ2UuZ28=) | `100.00% <ø> (ø)` | |
   | [filter/filter\_impl/auth/consumer\_sign.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvY29uc3VtZXJfc2lnbi5nbw==) | `60.00% <ø> (ø)` | |
   | [filter/filter\_impl/auth/default\_authenticator.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvZGVmYXVsdF9hdXRoZW50aWNhdG9yLmdv) | `80.00% <ø> (ø)` | |
   | [filter/filter\_impl/auth/provider\_auth.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvcHJvdmlkZXJfYXV0aC5nbw==) | `52.94% <ø> (ø)` | |
   | [filter/filter\_impl/auth/sign\_util.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvc2lnbl91dGlsLmdv) | `69.23% <ø> (ø)` | |
   | [filter/filter\_impl/echo\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2VjaG9fZmlsdGVyLmdv) | `85.71% <ø> (ø)` | |
   | [filter/filter\_impl/execute\_limit\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2V4ZWN1dGVfbGltaXRfZmlsdGVyLmdv) | `73.80% <ø> (ø)` | |
   | [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `67.69% <ø> (ø)` | |
   | ... and [35 more](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=footer). Last update [4af26b9...e03e24e](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter commented on pull request #586: Mod: update the comments in filter directory

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #586:
URL: https://github.com/apache/dubbo-go/pull/586#issuecomment-638963451


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=h1) Report
   > Merging [#586](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **increase** coverage by `0.52%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/586/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #586      +/-   ##
   ===========================================
   + Coverage    66.43%   66.95%   +0.52%     
   ===========================================
     Files          184      184              
     Lines         9712     9690      -22     
   ===========================================
   + Hits          6452     6488      +36     
   + Misses        2620     2563      -57     
   + Partials       640      639       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <ø> (ø)` | |
   | [filter/filter\_impl/active\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2FjdGl2ZV9maWx0ZXIuZ28=) | `66.66% <ø> (ø)` | |
   | [filter/filter\_impl/auth/accesskey\_storage.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvYWNjZXNza2V5X3N0b3JhZ2UuZ28=) | `100.00% <ø> (ø)` | |
   | [filter/filter\_impl/auth/consumer\_sign.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvY29uc3VtZXJfc2lnbi5nbw==) | `60.00% <ø> (ø)` | |
   | [filter/filter\_impl/auth/default\_authenticator.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvZGVmYXVsdF9hdXRoZW50aWNhdG9yLmdv) | `80.00% <ø> (ø)` | |
   | [filter/filter\_impl/auth/provider\_auth.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvcHJvdmlkZXJfYXV0aC5nbw==) | `52.94% <ø> (ø)` | |
   | [filter/filter\_impl/auth/sign\_util.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvc2lnbl91dGlsLmdv) | `69.23% <ø> (ø)` | |
   | [filter/filter\_impl/echo\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2VjaG9fZmlsdGVyLmdv) | `85.71% <ø> (ø)` | |
   | [filter/filter\_impl/execute\_limit\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2V4ZWN1dGVfbGltaXRfZmlsdGVyLmdv) | `73.80% <ø> (ø)` | |
   | [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `67.69% <ø> (ø)` | |
   | ... and [31 more](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=footer). Last update [4af26b9...b0c34c2](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] zouyx commented on a change in pull request #586: Mod: update the comments in filter directory

Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #586:
URL: https://github.com/apache/dubbo-go/pull/586#discussion_r435709497



##########
File path: common/extension/auth.go
##########
@@ -32,7 +32,7 @@ func SetAuthenticator(name string, fcn func() filter.Authenticator) {
 }
 
 // GetAuthenticator finds the Authenticator with @name
-// if not found, it will panic
+// panic if not found

Review comment:
       ```suggestion
   // Panic if not found
   ```

##########
File path: filter/filter_impl/graceful_shutdown_filter.go
##########
@@ -62,6 +63,7 @@ func (gf *gracefulShutdownFilter) Invoke(ctx context.Context, invoker protocol.I
 	return invoker.Invoke(ctx, invocation)
 }
 
+// OnResponse reduce the number of active processes then return the process result

Review comment:
       ```suggestion
   // OnResponse reduces the number of active processes then return the process result
   ```

##########
File path: filter/filter_impl/graceful_shutdown_filter.go
##########
@@ -53,6 +53,7 @@ type gracefulShutdownFilter struct {
 	shutdownConfig *config.ShutdownConfig
 }
 
+// Invoke add the requests count and block the new requests if application is closing

Review comment:
       ```suggestion
   // Invoke adds the requests count and block the new requests if application is closing
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #586: Mod: update the comments in filter directory

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #586:
URL: https://github.com/apache/dubbo-go/pull/586#issuecomment-638963451


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=h1) Report
   > Merging [#586](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/4af26b99cdcea223122bec0e90767bd56fad99f8&el=desc) will **increase** coverage by `0.52%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/586/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #586      +/-   ##
   ===========================================
   + Coverage    66.43%   66.95%   +0.52%     
   ===========================================
     Files          184      184              
     Lines         9712     9690      -22     
   ===========================================
   + Hits          6452     6488      +36     
   + Misses        2620     2563      -57     
   + Partials       640      639       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [common/extension/auth.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-Y29tbW9uL2V4dGVuc2lvbi9hdXRoLmdv) | `0.00% <ø> (ø)` | |
   | [filter/filter\_impl/active\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2FjdGl2ZV9maWx0ZXIuZ28=) | `66.66% <ø> (ø)` | |
   | [filter/filter\_impl/auth/accesskey\_storage.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvYWNjZXNza2V5X3N0b3JhZ2UuZ28=) | `100.00% <ø> (ø)` | |
   | [filter/filter\_impl/auth/consumer\_sign.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvY29uc3VtZXJfc2lnbi5nbw==) | `60.00% <ø> (ø)` | |
   | [filter/filter\_impl/auth/default\_authenticator.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvZGVmYXVsdF9hdXRoZW50aWNhdG9yLmdv) | `80.00% <ø> (ø)` | |
   | [filter/filter\_impl/auth/provider\_auth.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvcHJvdmlkZXJfYXV0aC5nbw==) | `52.94% <ø> (ø)` | |
   | [filter/filter\_impl/auth/sign\_util.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2F1dGgvc2lnbl91dGlsLmdv) | `69.23% <ø> (ø)` | |
   | [filter/filter\_impl/echo\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2VjaG9fZmlsdGVyLmdv) | `85.71% <ø> (ø)` | |
   | [filter/filter\_impl/execute\_limit\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2V4ZWN1dGVfbGltaXRfZmlsdGVyLmdv) | `73.80% <ø> (ø)` | |
   | [filter/filter\_impl/generic\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2dlbmVyaWNfZmlsdGVyLmdv) | `67.69% <ø> (ø)` | |
   | ... and [31 more](https://codecov.io/gh/apache/dubbo-go/pull/586/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=footer). Last update [4af26b9...e03e24e](https://codecov.io/gh/apache/dubbo-go/pull/586?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org