You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2025/11/23 21:55:37 UTC

(spark) branch master updated: [SPARK-54458][INFRA] Use official download-artifact to fix the test_report action

This is an automated email from the ASF dual-hosted git repository.

gurwls223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/master by this push:
     new 4506f2fe9bff [SPARK-54458][INFRA] Use official download-artifact to fix the test_report action
4506f2fe9bff is described below

commit 4506f2fe9bffbf923cb0db14151076879f947546
Author: Tian Gao <ga...@hotmail.com>
AuthorDate: Mon Nov 24 06:55:24 2025 +0900

    [SPARK-54458][INFRA] Use official download-artifact to fix the test_report action
    
    ### What changes were proposed in this pull request?
    
    We should fix the `test_report` workflow - it barely works.
    
    * Used the official download-artifacts to replace the 3rd party one
    * Unpinned the specific version of test report action
    * Used explicit permissions for the action
    
    ### Why are the changes needed?
    
    The problem is the 3rd party action used can't deal with non-zip files. In the orignal [PR](https://github.com/apache/spark/pull/29333) it was mentioned that the official `download-artifact` action should be used when it can download from other workflows. We should try to use that.
    
    ### Does this PR introduce _any_ user-facing change?
    
    No
    
    ### How was this patch tested?
    
    CI
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    No
    
    Closes #53167 from gaogaotiantian/fix-report-action.
    
    Authored-by: Tian Gao <ga...@hotmail.com>
    Signed-off-by: Hyukjin Kwon <gu...@apache.org>
---
 .github/workflows/test_report.yml | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/test_report.yml b/.github/workflows/test_report.yml
index 9ab69af42c81..d0e2ac8fe569 100644
--- a/.github/workflows/test_report.yml
+++ b/.github/workflows/test_report.yml
@@ -28,16 +28,19 @@ jobs:
   test_report:
     if: github.event.workflow_run.conclusion != 'skipped'
     runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      checks: write
+      contents: read
     steps:
     - name: Download test results to report
-      uses: dawidd6/action-download-artifact@bf251b5aa9c2f7eeb574a96ee720e24f801b7c11 # pin @v6
+      uses: actions/download-artifact@v5
       with:
-        github_token: ${{ secrets.GITHUB_TOKEN }}
-        workflow: ${{ github.event.workflow_run.workflow_id }}
-        commit: ${{ github.event.workflow_run.head_commit.id }}
-        workflow_conclusion: completed
+        github-token: ${{ secrets.GITHUB_TOKEN }}
+        run-id: ${{ github.event.workflow_run.id }}
+        pattern: "test-*"
     - name: Publish test report
-      uses: scacap/action-surefire-report@a2911bd1a4412ec18dde2d93b1758b3e56d2a880 # pin @v1.8.0
+      uses: scacap/action-surefire-report@v1
       with:
         check_name: Report test results
         github_token: ${{ secrets.GITHUB_TOKEN }}


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org