You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "Wang-qing-yang (via GitHub)" <gi...@apache.org> on 2023/05/18 02:35:38 UTC
[GitHub] [shardingsphere] Wang-qing-yang opened a new pull request, #25752: add PostgreSQL pg_catalog table
Wang-qing-yang opened a new pull request, #25752:
URL: https://github.com/apache/shardingsphere/pull/25752
Fixes #24662 .
Changes proposed in this pull request:
- add pg_aggregate table in pg_catalog for PostgreSQL
- add test cases
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaojinchao95 commented on a diff in pull request #25752: add PostgreSQL pg_catalog table
Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 commented on code in PR #25752:
URL: https://github.com/apache/shardingsphere/pull/25752#discussion_r1197289011
##########
test/e2e/sql/src/test/resources/cases/dql/dataset/db/select_postgresql_pg_catalog_pg_aggregate.xml:
##########
@@ -0,0 +1,43 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<dataset>
+ <metadata>
+ <column name="aggfnoid" />
+ <column name="aggkind" />
+ <column name="aggnumdirectargs" />
+ <column name="aggtransfn" />
+ <column name="aggfinalfn" />
+ <column name="aggcombinefn" />
+ <column name="aggserialfn" />
+ <column name="aggdeserialfn" />
+ <column name="aggmtransfn" />
+ <column name="aggminvtransfn" />
+ <column name="aggmfinalfn" />
+ <column name="aggfinalextra" />
+ <column name="aggmfinalextra" />
+ <column name="aggfinalmodify" />
+ <column name="aggmfinalmodify" />
+ <column name="aggsortop" />
+ <column name="aggtranstype" />
+ <column name="aggtransspace" />
+ <column name="aggmtranstype" />
+ <column name="aggmtransspace" />
+ <column name="agginitval" />
+ <column name="aggminitval" />
+ </metadata>
+</dataset>
Review Comment:
Please add new blank line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Wang-qing-yang commented on a diff in pull request #25752: add PostgreSQL pg_catalog table
Posted by "Wang-qing-yang (via GitHub)" <gi...@apache.org>.
Wang-qing-yang commented on code in PR #25752:
URL: https://github.com/apache/shardingsphere/pull/25752#discussion_r1197589417
##########
test/e2e/sql/src/test/resources/cases/dql/dataset/db/select_postgresql_pg_catalog_pg_aggregate.xml:
##########
@@ -0,0 +1,43 @@
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
+ ~ contributor license agreements. See the NOTICE file distributed with
+ ~ this work for additional information regarding copyright ownership.
+ ~ The ASF licenses this file to You under the Apache License, Version 2.0
+ ~ (the "License"); you may not use this file except in compliance with
+ ~ the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing, software
+ ~ distributed under the License is distributed on an "AS IS" BASIS,
+ ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ ~ See the License for the specific language governing permissions and
+ ~ limitations under the License.
+ -->
+
+<dataset>
+ <metadata>
+ <column name="aggfnoid" />
+ <column name="aggkind" />
+ <column name="aggnumdirectargs" />
+ <column name="aggtransfn" />
+ <column name="aggfinalfn" />
+ <column name="aggcombinefn" />
+ <column name="aggserialfn" />
+ <column name="aggdeserialfn" />
+ <column name="aggmtransfn" />
+ <column name="aggminvtransfn" />
+ <column name="aggmfinalfn" />
+ <column name="aggfinalextra" />
+ <column name="aggmfinalextra" />
+ <column name="aggfinalmodify" />
+ <column name="aggmfinalmodify" />
+ <column name="aggsortop" />
+ <column name="aggtranstype" />
+ <column name="aggtransspace" />
+ <column name="aggmtranstype" />
+ <column name="aggmtransspace" />
+ <column name="agginitval" />
+ <column name="aggminitval" />
+ </metadata>
+</dataset>
Review Comment:
already fixed, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] FlyingZC merged pull request #25752: add PostgreSQL pg_catalog table
Posted by "FlyingZC (via GitHub)" <gi...@apache.org>.
FlyingZC merged PR #25752:
URL: https://github.com/apache/shardingsphere/pull/25752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org