You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2019/04/05 18:49:16 UTC

[kudu-CR] [build] Fix building codegen on MacOS Mojave

Hello Will Berkeley, Alexey Serbin, Kudu Jenkins, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12936

to look at the new patch set (#2).

Change subject: [build] Fix building codegen on MacOS Mojave
......................................................................

[build] Fix building codegen on MacOS Mojave

When macOS_SDK_headers_for_macOS_10.14 is installed setting the
--sysroot to the default header location breaks the build, which is why
there was a check whether /usr/include existed and only set --sysroot to
the SDK path if it didn't.

The problem with this is if something creates the /usr/include
directory, the build will fail again. This commit changes the check to
look for /usr/include/libc.h instead.

Change-Id: I29ec74014bee3121bfb4a203dd7bfa8bac8f8321
---
M src/kudu/codegen/CMakeLists.txt
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/12936/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12936
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I29ec74014bee3121bfb4a203dd7bfa8bac8f8321
Gerrit-Change-Number: 12936
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>