You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/12 18:17:53 UTC

[GitHub] [apisix] azilentech commented on pull request #6586: feat: add support for password grant in keycloak plugin

azilentech commented on pull request #6586:
URL: https://github.com/apache/apisix/pull/6586#issuecomment-1065934827


   Hi,
   
   I will need little guidance for the CLA signing process from your side.
   
   In PR, I have made the following changes.
   
   - Added test cases. As these test cases require keycloak installation, I tested with my local environment by adjusting parameters and configuration settings. Please let me know If I need to perform further steps.
   - I updated code by using better configuration setting "password_grant_token_generation_incoming_uri" instead of using "token_generation_endpoint" which can be confusing with "token_endpoint".
   - I updated the documentation by following contribution guidelines.
   - I also ran "make lint" and followed all the suggestions.
   
   Please let me know the next actions for me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org