You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Senaka Fernando (JIRA)" <ji...@apache.org> on 2008/07/17 21:47:31 UTC

[jira] Created: (HARMONY-5917) localization of Harmony VM

localization of Harmony VM
--------------------------

                 Key: HARMONY-5917
                 URL: https://issues.apache.org/jira/browse/HARMONY-5917
             Project: Harmony
          Issue Type: Improvement
          Components: VM
            Reporter: Senaka Fernando


localization of Harmony VM, by replacing WARN with LWARN and DIE with LDIE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5917) localization of Harmony VM

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617299#action_12617299 ] 

Alexei Fedotov commented on HARMONY-5917:
-----------------------------------------

Committed at 680117 with few compilation fixes. Senaka, please, check that the patch is applied as expected.

> localization of Harmony VM
> --------------------------
>
>                 Key: HARMONY-5917
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5917
>             Project: Harmony
>          Issue Type: Improvement
>          Components: VM
>            Reporter: Senaka Fernando
>            Assignee: Alexei Fedotov
>         Attachments: harmony-5917.patch.txt
>
>
> localization of Harmony VM, by replacing WARN with LWARN and DIE with LDIE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5917) localization of Harmony VM

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617295#action_12617295 ] 

Alexei Fedotov commented on HARMONY-5917:
-----------------------------------------

Senaka,
Why LDIE085 appears twice at the patch for working_vm/vm/vmcore/src/init/harmony.properties?

BTW, replacing clog.h with cxxlog.h in the low-level code is pretty unsafe operation because DRLVM does not handle stack unwinding in a C++-like way. I could not see any particular problems right now but would suggest discussing such changes on the list before making them (and better avoid making potentially unsafe changes).


> localization of Harmony VM
> --------------------------
>
>                 Key: HARMONY-5917
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5917
>             Project: Harmony
>          Issue Type: Improvement
>          Components: VM
>            Reporter: Senaka Fernando
>            Assignee: Alexei Fedotov
>         Attachments: harmony-5917.patch.txt
>
>
> localization of Harmony VM, by replacing WARN with LWARN and DIE with LDIE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5917) localization of Harmony VM

Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617297#action_12617297 ] 

Senaka Fernando commented on HARMONY-5917:
------------------------------------------

Hi Alexei,

Sorry about the LDIE085 issue. I have made a blunder in the diff. I had to remove certain portions from the diff since they were not related to this issue. While doing that a mysterious line has been added. :)... Will have that corrected.

Thanks,
Senaka

> localization of Harmony VM
> --------------------------
>
>                 Key: HARMONY-5917
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5917
>             Project: Harmony
>          Issue Type: Improvement
>          Components: VM
>            Reporter: Senaka Fernando
>            Assignee: Alexei Fedotov
>         Attachments: harmony-5917.patch.txt
>
>
> localization of Harmony VM, by replacing WARN with LWARN and DIE with LDIE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-5917) localization of Harmony VM

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov reassigned HARMONY-5917:
---------------------------------------

    Assignee: Alexei Fedotov

> localization of Harmony VM
> --------------------------
>
>                 Key: HARMONY-5917
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5917
>             Project: Harmony
>          Issue Type: Improvement
>          Components: VM
>            Reporter: Senaka Fernando
>            Assignee: Alexei Fedotov
>         Attachments: harmony-5917.patch.txt
>
>
> localization of Harmony VM, by replacing WARN with LWARN and DIE with LDIE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5917) localization of Harmony VM

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617284#action_12617284 ] 

Alexei Fedotov commented on HARMONY-5917:
-----------------------------------------

I could not make a debug version of DRLVM work: got crash with 53 error code. Fortunately I got a Microsoft "heroes" pack with MSVC debugger - if it would work, I would locate a crash. Otherwise I'm to revive my Linux.

> localization of Harmony VM
> --------------------------
>
>                 Key: HARMONY-5917
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5917
>             Project: Harmony
>          Issue Type: Improvement
>          Components: VM
>            Reporter: Senaka Fernando
>            Assignee: Alexei Fedotov
>         Attachments: harmony-5917.patch.txt
>
>
> localization of Harmony VM, by replacing WARN with LWARN and DIE with LDIE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5917) localization of Harmony VM

Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617276#action_12617276 ] 

Senaka Fernando commented on HARMONY-5917:
------------------------------------------

Hi Alexei,

I found that the classloader.cpp infact had an error. I'm still in search of the other two. However, 'ant test' and 'ant test2' don't seem to work with or with out the patch. I doubt whether I'm missing anything here.

Also, I'm on a Ubuntu Hardy using gcc version 4.2.3 (Ubuntu 4.2.3-2ubuntu7).

Regards,
Senaka

> localization of Harmony VM
> --------------------------
>
>                 Key: HARMONY-5917
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5917
>             Project: Harmony
>          Issue Type: Improvement
>          Components: VM
>            Reporter: Senaka Fernando
>            Assignee: Alexei Fedotov
>         Attachments: harmony-5917.patch.txt
>
>
> localization of Harmony VM, by replacing WARN with LWARN and DIE with LDIE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5917) localization of Harmony VM

Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Senaka Fernando updated HARMONY-5917:
-------------------------------------

    Attachment: harmony-5917.patch.txt

> localization of Harmony VM
> --------------------------
>
>                 Key: HARMONY-5917
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5917
>             Project: Harmony
>          Issue Type: Improvement
>          Components: VM
>            Reporter: Senaka Fernando
>         Attachments: harmony-5917.patch.txt
>
>
> localization of Harmony VM, by replacing WARN with LWARN and DIE with LDIE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5917) localization of Harmony VM

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov updated HARMONY-5917:
------------------------------------

    Comment: was deleted

> localization of Harmony VM
> --------------------------
>
>                 Key: HARMONY-5917
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5917
>             Project: Harmony
>          Issue Type: Improvement
>          Components: VM
>            Reporter: Senaka Fernando
>            Assignee: Alexei Fedotov
>         Attachments: harmony-5917.patch.txt
>
>
> localization of Harmony VM, by replacing WARN with LWARN and DIE with LDIE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5917) localization of Harmony VM

Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Senaka Fernando updated HARMONY-5917:
-------------------------------------

    Attachment: harmony-5917.patch.txt

> localization of Harmony VM
> --------------------------
>
>                 Key: HARMONY-5917
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5917
>             Project: Harmony
>          Issue Type: Improvement
>          Components: VM
>            Reporter: Senaka Fernando
>         Attachments: harmony-5917.patch.txt
>
>
> localization of Harmony VM, by replacing WARN with LWARN and DIE with LDIE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5917) localization of Harmony VM

Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Senaka Fernando updated HARMONY-5917:
-------------------------------------

    Attachment: harmony-5917.patch.txt

> localization of Harmony VM
> --------------------------
>
>                 Key: HARMONY-5917
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5917
>             Project: Harmony
>          Issue Type: Improvement
>          Components: VM
>            Reporter: Senaka Fernando
>            Assignee: Alexei Fedotov
>         Attachments: harmony-5917.patch.txt
>
>
> localization of Harmony VM, by replacing WARN with LWARN and DIE with LDIE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5917) localization of Harmony VM

Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617320#action_12617320 ] 

Senaka Fernando commented on HARMONY-5917:
------------------------------------------

Hi Alexei,

The "ant clean build" which should in theory alarm the miss-use of ',' in place of '<<' doesn't seem to trigger. I believe the behaviour looks a bit different on my system. As I said before, I did not see a build error due to this. The possibilities are that the clean does not in fact clean code in that area.

The patch seems to be applied ok. There is a mismatch in WARN053 in the harmony.properties and working_vm/vm/gc_gen/src/common/large_pages.cpp. You've corrected one but left the other intact.

I will add to this issue, further modifications which will replace remaining references to DIE with LDIE. Some instances are straightforward where as some aren't, I will post to the list as I progress.

Regards,
Senaka

> localization of Harmony VM
> --------------------------
>
>                 Key: HARMONY-5917
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5917
>             Project: Harmony
>          Issue Type: Improvement
>          Components: VM
>            Reporter: Senaka Fernando
>            Assignee: Alexei Fedotov
>         Attachments: harmony-5917.patch.txt
>
>
> localization of Harmony VM, by replacing WARN with LWARN and DIE with LDIE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5917) localization of Harmony VM

Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Senaka Fernando updated HARMONY-5917:
-------------------------------------

    Attachment:     (was: harmony-5917.patch.txt)

> localization of Harmony VM
> --------------------------
>
>                 Key: HARMONY-5917
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5917
>             Project: Harmony
>          Issue Type: Improvement
>          Components: VM
>            Reporter: Senaka Fernando
>
> localization of Harmony VM, by replacing WARN with LWARN and DIE with LDIE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-5917) localization of Harmony VM

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexei Fedotov closed HARMONY-5917.
-----------------------------------

    Resolution: Fixed

Fixed at 680117. No objection to close.

> localization of Harmony VM
> --------------------------
>
>                 Key: HARMONY-5917
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5917
>             Project: Harmony
>          Issue Type: Improvement
>          Components: VM
>            Reporter: Senaka Fernando
>            Assignee: Alexei Fedotov
>         Attachments: harmony-5917.patch.txt
>
>
> localization of Harmony VM, by replacing WARN with LWARN and DIE with LDIE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5917) localization of Harmony VM

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617289#action_12617289 ] 

Alexei Fedotov commented on HARMONY-5917:
-----------------------------------------

My problem was a known issue. I need to find four msvc debugging dlls to make things wok.

> localization of Harmony VM
> --------------------------
>
>                 Key: HARMONY-5917
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5917
>             Project: Harmony
>          Issue Type: Improvement
>          Components: VM
>            Reporter: Senaka Fernando
>            Assignee: Alexei Fedotov
>         Attachments: harmony-5917.patch.txt
>
>
> localization of Harmony VM, by replacing WARN with LWARN and DIE with LDIE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5917) localization of Harmony VM

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617274#action_12617274 ] 

Alexei Fedotov commented on HARMONY-5917:
-----------------------------------------

I have fixed three syntax errors and see a crash with exit code 53 compared to the clean build. This make difficult to trace this any further without a debugger (btw, funny enough, it seems that our crash handler does not work).

> localization of Harmony VM
> --------------------------
>
>                 Key: HARMONY-5917
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5917
>             Project: Harmony
>          Issue Type: Improvement
>          Components: VM
>            Reporter: Senaka Fernando
>            Assignee: Alexei Fedotov
>         Attachments: harmony-5917.patch.txt
>
>
> localization of Harmony VM, by replacing WARN with LWARN and DIE with LDIE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5917) localization of Harmony VM

Posted by "Alexei Fedotov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617270#action_12617270 ] 

Alexei Fedotov commented on HARMONY-5917:
-----------------------------------------

Senaka, threading module does not support LDIE. The submitted patches for VM should pass "ant test" for any of supported platforms, i.e. you have to run a small set of tests before submitting the patch.

> localization of Harmony VM
> --------------------------
>
>                 Key: HARMONY-5917
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5917
>             Project: Harmony
>          Issue Type: Improvement
>          Components: VM
>            Reporter: Senaka Fernando
>         Attachments: harmony-5917.patch.txt
>
>
> localization of Harmony VM, by replacing WARN with LWARN and DIE with LDIE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5917) localization of Harmony VM

Posted by "Senaka Fernando (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Senaka Fernando updated HARMONY-5917:
-------------------------------------

    Attachment:     (was: harmony-5917.patch.txt)

> localization of Harmony VM
> --------------------------
>
>                 Key: HARMONY-5917
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5917
>             Project: Harmony
>          Issue Type: Improvement
>          Components: VM
>            Reporter: Senaka Fernando
>            Assignee: Alexei Fedotov
>         Attachments: harmony-5917.patch.txt
>
>
> localization of Harmony VM, by replacing WARN with LWARN and DIE with LDIE.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.