You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@bahir.apache.org by lukasz-antoniak <gi...@git.apache.org> on 2018/12/12 17:22:40 UTC

[GitHub] bahir pull request #77: Ignore flaky PubNub integration test

GitHub user lukasz-antoniak opened a pull request:

    https://github.com/apache/bahir/pull/77

    Ignore flaky PubNub integration test

    Anyone playing with PubNub demo can interrupt integration tests. Not to incorrectly fail builds, let us mute tests directly interacting with PubNub cloud (similar to Google PubSub). False alarms can be observed in pull requests #75 and #76. After merging #73, changes are minimal :).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lukasz-antoniak/bahir flaky-pubnub

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bahir/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #77
    
----
commit cad778b2499f95e7d36cf5e7c6872eaff07401d0
Author: Lukasz Antoniak <lu...@...>
Date:   2018-12-12T17:17:38Z

    Ignore flaky PubNub integration test

----


---

[GitHub] bahir pull request #77: Ignore flaky PubNub integration test

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/bahir/pull/77


---