[GitHub] [airflow] potiuk commented on pull request #15731: extra docker-py to 4.4.x resolve docker op issues

[GitBox <gi...@apache.org>]

potiuk commented on pull request #15731:
URL: https://github.com/apache/airflow/pull/15731#issuecomment-835197520


   It makes me nervous as well. Let's see if the test succeed. 
   
   FYI: Whenever you update setup.py in your PR, the image is built following a bit different route (it uses --upgrade --upgrade-strategy eager rather than constraints, so we should get an updated docker library. 
   
   I think if all the tests pass and if you teste a simple DAG, that should be fine. Docker Operator and Docker Hook are rather straightforward and simple. 
   
   Re version - I think ~=4.4.1 is a bit too 'cautious". With our constraint mechanism we can relax it much more. the constraints are never upgraded if tests are failed (we have an automated mechanism that does it - similar to dependabot PRs but a bit more complex due to the constraint mechanism). I'd say I would even try to remove the limit altogether and repeat the tests for the 5.0.0 version which has been released at the beginning of April.
   
   I am happy to make some tests after that as well. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org