[GitHub] [druid] xvrl commented on a change in pull request #11363: upgrade error-prone to 2.7.1 and support checks with Java 11+

[GitBox <gi...@apache.org>]

xvrl commented on a change in pull request #11363:
URL: https://github.com/apache/druid/pull/11363#discussion_r652119258



##########
File path: core/src/main/java/org/apache/druid/crypto/CryptoService.java
##########
@@ -113,6 +113,7 @@ public CryptoService(
 
       SecretKey tmp = getKeyFromPassword(passPhrase, salt);
       SecretKey secret = new SecretKeySpec(tmp.getEncoded(), cipherAlgName);
+      @SuppressWarnings("InsecureCryptoUsage")

Review comment:
       error-prone warns if the ciphers are not compile-time constants that it can inspect for insecure defaults.
   In our case our defaults are secure, but I can add a comment if that helps.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org