You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Si Chen (JIRA)" <ji...@apache.org> on 2006/09/12 17:45:22 UTC
[jira] Created: (OFBIZ-240) selectAll on multi-forms
selectAll on multi-forms
------------------------
Key: OFBIZ-240
URL: http://issues.apache.org/jira/browse/OFBIZ-240
Project: OFBiz (The Open for Business Project)
Issue Type: Improvement
Components: framework
Reporter: Si Chen
Priority: Minor
Add a "select-all" button to multi-forms. Comments from mailing list:
Si,
I think you're right that this is broken. I just looked around for anything in the form widget code referring to the "toggleAll" method and it's not there... So, yeah, in the HtmlFormRenderer we should add the normal checkbox to the header as is used elsewhere, like this:
<input type="checkbox" name="selectAll" value="Y" onclick="javascript:toggleAll(this, 'selectAllForm');"/>
The "selectAllForm" string should be replaced dynamically with the form name, and then that should do it... The rowSubmit fields should already be going in with the use-row-submit attribute set to true.
-David
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (OFBIZ-240) selectAll on multi-forms
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-240?page=all ]
Jacques Le Roux closed OFBIZ-240.
---------------------------------
Resolution: Fixed
According to Leon Torres (11/10/2006) this has been committed as r449813
Jacques
> selectAll on multi-forms
> ------------------------
>
> Key: OFBIZ-240
> URL: http://issues.apache.org/jira/browse/OFBIZ-240
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assigned To: Si Chen
> Priority: Minor
> Attachments: selectAllSmallestImpact.patch
>
>
> Add a "select-all" button to multi-forms. Comments from mailing list:
> Si,
> I think you're right that this is broken. I just looked around for anything in the form widget code referring to the "toggleAll" method and it's not there... So, yeah, in the HtmlFormRenderer we should add the normal checkbox to the header as is used elsewhere, like this:
> <input type="checkbox" name="selectAll" value="Y" onclick="javascript:toggleAll(this, 'selectAllForm');"/>
> The "selectAllForm" string should be replaced dynamically with the form name, and then that should do it... The rowSubmit fields should already be going in with the use-row-submit attribute set to true.
> -David
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (OFBIZ-240) selectAll on multi-forms
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-240?page=all ]
Si Chen reassigned OFBIZ-240:
-----------------------------
Assignee: Si Chen
> selectAll on multi-forms
> ------------------------
>
> Key: OFBIZ-240
> URL: http://issues.apache.org/jira/browse/OFBIZ-240
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assigned To: Si Chen
> Priority: Minor
> Attachments: selectAllSmallestImpact.patch
>
>
> Add a "select-all" button to multi-forms. Comments from mailing list:
> Si,
> I think you're right that this is broken. I just looked around for anything in the form widget code referring to the "toggleAll" method and it's not there... So, yeah, in the HtmlFormRenderer we should add the normal checkbox to the header as is used elsewhere, like this:
> <input type="checkbox" name="selectAll" value="Y" onclick="javascript:toggleAll(this, 'selectAllForm');"/>
> The "selectAllForm" string should be replaced dynamically with the form name, and then that should do it... The rowSubmit fields should already be going in with the use-row-submit attribute set to true.
> -David
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-240) selectAll on multi-forms
Posted by "Leon Torres (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-240?page=all ]
Leon Torres updated OFBIZ-240:
------------------------------
Attachment: selectAllSmallestImpact.patch
Here's the smallest impact patch for this feature.
To generate the select all, the user must define a <field name="_rowSubmit" title="somethingOrElse"><check/></field> in a form of type "multi". The magic field name is because of selectall.js.
> selectAll on multi-forms
> ------------------------
>
> Key: OFBIZ-240
> URL: http://issues.apache.org/jira/browse/OFBIZ-240
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Priority: Minor
> Attachments: selectAllSmallestImpact.patch
>
>
> Add a "select-all" button to multi-forms. Comments from mailing list:
> Si,
> I think you're right that this is broken. I just looked around for anything in the form widget code referring to the "toggleAll" method and it's not there... So, yeah, in the HtmlFormRenderer we should add the normal checkbox to the header as is used elsewhere, like this:
> <input type="checkbox" name="selectAll" value="Y" onclick="javascript:toggleAll(this, 'selectAllForm');"/>
> The "selectAllForm" string should be replaced dynamically with the form name, and then that should do it... The rowSubmit fields should already be going in with the use-row-submit attribute set to true.
> -David
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (OFBIZ-240) selectAll on multi-forms
Posted by David E Jones <jo...@undersunconsulting.com>.
Nope, no objection here. Of course, as for the empty title problem...
I haven't looked at that code for a while but chances are it's a bit
messy. As long as it doesn't break things you know I'm always for
ripping up/out code... ;)
-David
On Sep 23, 2006, at 12:28 AM, Si Chen (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/OFBIZ-240?
> page=comments#action_12437029 ]
>
> Si Chen commented on OFBIZ-240:
> -------------------------------
>
> Hey everybody, let me know if there are any objections to this.
> Otherwise I'll commit it on Monday.
>
>> selectAll on multi-forms
>> ------------------------
>>
>> Key: OFBIZ-240
>> URL: http://issues.apache.org/jira/browse/OFBIZ-240
>> Project: OFBiz (The Open for Business Project)
>> Issue Type: Improvement
>> Components: framework
>> Reporter: Si Chen
>> Assigned To: Si Chen
>> Priority: Minor
>> Attachments: selectAllSmallestImpact.patch
>>
>>
>> Add a "select-all" button to multi-forms. Comments from mailing
>> list:
>> Si,
>> I think you're right that this is broken. I just looked around for
>> anything in the form widget code referring to the "toggleAll"
>> method and it's not there... So, yeah, in the HtmlFormRenderer we
>> should add the normal checkbox to the header as is used elsewhere,
>> like this:
>> <input type="checkbox" name="selectAll" value="Y"
>> onclick="javascript:toggleAll(this, 'selectAllForm');"/>
>> The "selectAllForm" string should be replaced dynamically with the
>> form name, and then that should do it... The rowSubmit fields
>> should already be going in with the use-row-submit attribute set
>> to true.
>> -David
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the
> administrators: http://issues.apache.org/jira/secure/
> Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/
> software/jira
>
>
[jira] Commented: (OFBIZ-240) selectAll on multi-forms
Posted by "Si Chen (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-240?page=comments#action_12437029 ]
Si Chen commented on OFBIZ-240:
-------------------------------
Hey everybody, let me know if there are any objections to this. Otherwise I'll commit it on Monday.
> selectAll on multi-forms
> ------------------------
>
> Key: OFBIZ-240
> URL: http://issues.apache.org/jira/browse/OFBIZ-240
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Assigned To: Si Chen
> Priority: Minor
> Attachments: selectAllSmallestImpact.patch
>
>
> Add a "select-all" button to multi-forms. Comments from mailing list:
> Si,
> I think you're right that this is broken. I just looked around for anything in the form widget code referring to the "toggleAll" method and it's not there... So, yeah, in the HtmlFormRenderer we should add the normal checkbox to the header as is used elsewhere, like this:
> <input type="checkbox" name="selectAll" value="Y" onclick="javascript:toggleAll(this, 'selectAllForm');"/>
> The "selectAllForm" string should be replaced dynamically with the form name, and then that should do it... The rowSubmit fields should already be going in with the use-row-submit attribute set to true.
> -David
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-240) selectAll on multi-forms
Posted by "Leon Torres (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/OFBIZ-240?page=comments#action_12437024 ]
Leon Torres commented on OFBIZ-240:
-----------------------------------
By title="somethingOrElse", I mean the title is a required attribute. If no title is specified, the selectAll checkbox won't be generated. This is due to the limitation of the method that renders the header title, which only runs if title is not empty. To work around this would require ripping the code up more, which I didn't want to do.
> selectAll on multi-forms
> ------------------------
>
> Key: OFBIZ-240
> URL: http://issues.apache.org/jira/browse/OFBIZ-240
> Project: OFBiz (The Open for Business Project)
> Issue Type: Improvement
> Components: framework
> Reporter: Si Chen
> Priority: Minor
> Attachments: selectAllSmallestImpact.patch
>
>
> Add a "select-all" button to multi-forms. Comments from mailing list:
> Si,
> I think you're right that this is broken. I just looked around for anything in the form widget code referring to the "toggleAll" method and it's not there... So, yeah, in the HtmlFormRenderer we should add the normal checkbox to the header as is used elsewhere, like this:
> <input type="checkbox" name="selectAll" value="Y" onclick="javascript:toggleAll(this, 'selectAllForm');"/>
> The "selectAllForm" string should be replaced dynamically with the form name, and then that should do it... The rowSubmit fields should already be going in with the use-row-submit attribute set to true.
> -David
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira