You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/01/14 06:08:07 UTC

[GitHub] [hudi] danny0405 commented on a change in pull request #4589: [MINOR] Fix the check condition in the `readFromVector` method to alway true

danny0405 commented on a change in pull request #4589:
URL: https://github.com/apache/hudi/pull/4589#discussion_r784527723



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/AvroOrcUtils.java
##########
@@ -521,9 +522,6 @@ public static Object readFromVector(TypeDescription type, ColumnVector colVector
         } else {
           return ((BytesColumnVector) colVector).toString(vectorPos);
         }
-      case DATE:
-        // convert to daysSinceEpoch for LogicalType.Date

Review comment:
       Not sure what this patch fixed for ? Do you want to fix the NPE here ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org