You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ray Chen (JIRA)" <ji...@apache.org> on 2009/09/01 04:21:32 UTC
[jira] Created: (HARMONY-6327) [classlib][nio]FileChannelTest
failed on z/OS
[classlib][nio]FileChannelTest failed on z/OS
---------------------------------------------
Key: HARMONY-6327
URL: https://issues.apache.org/jira/browse/HARMONY-6327
Project: Harmony
Issue Type: Bug
Components: Classlib
Environment: z/OS platform
Reporter: Ray Chen
Attachments: 6327.diff
Failed on FileChannelTest.test_transferToJJLWritableByteChannel_SocketChannel
Both line 3062 & 3063 failed
Line 3062: 36 is expected but it gets 0
Line 3063: 10 is expected but it gets 38
Bug in modules/luni/src/main/native/luni/unix/OSFileSystemLinux32.c
send_file() function returns 0 if success
However it should return the count of trasfered bytes
And transefer should not change the position value
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6327) [classlib][nio]FileChannelTest
failed on z/OS
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Deakin updated HARMONY-6327:
-----------------------------------
Affects Version/s: 5.0M11
Fix Version/s: 5.0M12
> [classlib][nio]FileChannelTest failed on z/OS
> ---------------------------------------------
>
> Key: HARMONY-6327
> URL: https://issues.apache.org/jira/browse/HARMONY-6327
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M11
> Environment: z/OS platform
> Reporter: Ray Chen
> Assignee: Oliver Deakin
> Fix For: 5.0M12
>
> Attachments: 6327.diff, 6327_v2.diff
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Failed on FileChannelTest.test_transferToJJLWritableByteChannel_SocketChannel
> Both line 3062 & 3063 failed
> Line 3062: 36 is expected but it gets 0
> Line 3063: 10 is expected but it gets 38
> Bug in modules/luni/src/main/native/luni/unix/OSFileSystemLinux32.c
> send_file() function returns 0 if success
> However it should return the count of trasfered bytes
> And transefer should not change the position value
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-6327) [classlib][nio]FileChannelTest
failed on z/OS
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Deakin resolved HARMONY-6327.
------------------------------------
Resolution: Fixed
Thanks Ray - patch applied at repo revision r810468. I made a slight modification - I moved the declaration and initialisation of positionBack inside the AIX/ZOS block as it is not used outside, and I also added the declaration of the result variable as it was missing. Please check that changes applied are as expected.
> [classlib][nio]FileChannelTest failed on z/OS
> ---------------------------------------------
>
> Key: HARMONY-6327
> URL: https://issues.apache.org/jira/browse/HARMONY-6327
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M11
> Environment: z/OS platform
> Reporter: Ray Chen
> Assignee: Oliver Deakin
> Attachments: 6327.diff, 6327_v2.diff
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Failed on FileChannelTest.test_transferToJJLWritableByteChannel_SocketChannel
> Both line 3062 & 3063 failed
> Line 3062: 36 is expected but it gets 0
> Line 3063: 10 is expected but it gets 38
> Bug in modules/luni/src/main/native/luni/unix/OSFileSystemLinux32.c
> send_file() function returns 0 if success
> However it should return the count of trasfered bytes
> And transefer should not change the position value
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6327) [classlib][nio]FileChannelTest
failed on z/OS
Posted by "Ray Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ray Chen updated HARMONY-6327:
------------------------------
Attachment: (was: 6327.diff)
> [classlib][nio]FileChannelTest failed on z/OS
> ---------------------------------------------
>
> Key: HARMONY-6327
> URL: https://issues.apache.org/jira/browse/HARMONY-6327
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: z/OS platform
> Reporter: Ray Chen
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Failed on FileChannelTest.test_transferToJJLWritableByteChannel_SocketChannel
> Both line 3062 & 3063 failed
> Line 3062: 36 is expected but it gets 0
> Line 3063: 10 is expected but it gets 38
> Bug in modules/luni/src/main/native/luni/unix/OSFileSystemLinux32.c
> send_file() function returns 0 if success
> However it should return the count of trasfered bytes
> And transefer should not change the position value
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6327) [classlib][nio]FileChannelTest
failed on z/OS
Posted by "Ray Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ray Chen updated HARMONY-6327:
------------------------------
Attachment: 6327_v2.diff
Move z/OS and AIX to the same block because send_file() acts same on both platform
> [classlib][nio]FileChannelTest failed on z/OS
> ---------------------------------------------
>
> Key: HARMONY-6327
> URL: https://issues.apache.org/jira/browse/HARMONY-6327
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: z/OS platform
> Reporter: Ray Chen
> Assignee: Oliver Deakin
> Attachments: 6327.diff, 6327_v2.diff
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Failed on FileChannelTest.test_transferToJJLWritableByteChannel_SocketChannel
> Both line 3062 & 3063 failed
> Line 3062: 36 is expected but it gets 0
> Line 3063: 10 is expected but it gets 38
> Bug in modules/luni/src/main/native/luni/unix/OSFileSystemLinux32.c
> send_file() function returns 0 if success
> However it should return the count of trasfered bytes
> And transefer should not change the position value
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6327) [classlib][nio]FileChannelTest
failed on z/OS
Posted by "Ray Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ray Chen updated HARMONY-6327:
------------------------------
Attachment: 6327.diff
> [classlib][nio]FileChannelTest failed on z/OS
> ---------------------------------------------
>
> Key: HARMONY-6327
> URL: https://issues.apache.org/jira/browse/HARMONY-6327
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: z/OS platform
> Reporter: Ray Chen
> Attachments: 6327.diff
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Failed on FileChannelTest.test_transferToJJLWritableByteChannel_SocketChannel
> Both line 3062 & 3063 failed
> Line 3062: 36 is expected but it gets 0
> Line 3063: 10 is expected but it gets 38
> Bug in modules/luni/src/main/native/luni/unix/OSFileSystemLinux32.c
> send_file() function returns 0 if success
> However it should return the count of trasfered bytes
> And transefer should not change the position value
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-6327) [classlib][nio]FileChannelTest
failed on z/OS
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Deakin reassigned HARMONY-6327:
--------------------------------------
Assignee: Oliver Deakin
> [classlib][nio]FileChannelTest failed on z/OS
> ---------------------------------------------
>
> Key: HARMONY-6327
> URL: https://issues.apache.org/jira/browse/HARMONY-6327
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: z/OS platform
> Reporter: Ray Chen
> Assignee: Oliver Deakin
> Attachments: 6327.diff
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Failed on FileChannelTest.test_transferToJJLWritableByteChannel_SocketChannel
> Both line 3062 & 3063 failed
> Line 3062: 36 is expected but it gets 0
> Line 3063: 10 is expected but it gets 38
> Bug in modules/luni/src/main/native/luni/unix/OSFileSystemLinux32.c
> send_file() function returns 0 if success
> However it should return the count of trasfered bytes
> And transefer should not change the position value
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6327) [classlib][nio]FileChannelTest
failed on z/OS
Posted by "Ray Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750349#action_12750349 ]
Ray Chen commented on HARMONY-6327:
-----------------------------------
Hi Oliver,
I think you are right. I am trying to find some manual of AIX to make sure
the send_file return value.
I will update the patch when I am sure.
If you got some, let me know.
Thank you.
--
Ray Chen
MSN:clraychen@hotmail.com <MS...@hotmail.com>
Email:clarychen@gmail.com <Em...@gmail.com>
> [classlib][nio]FileChannelTest failed on z/OS
> ---------------------------------------------
>
> Key: HARMONY-6327
> URL: https://issues.apache.org/jira/browse/HARMONY-6327
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: z/OS platform
> Reporter: Ray Chen
> Assignee: Oliver Deakin
> Attachments: 6327.diff
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Failed on FileChannelTest.test_transferToJJLWritableByteChannel_SocketChannel
> Both line 3062 & 3063 failed
> Line 3062: 36 is expected but it gets 0
> Line 3063: 10 is expected but it gets 38
> Bug in modules/luni/src/main/native/luni/unix/OSFileSystemLinux32.c
> send_file() function returns 0 if success
> However it should return the count of trasfered bytes
> And transefer should not change the position value
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6327) [classlib][nio]FileChannelTest
failed on z/OS
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750344#action_12750344 ]
Oliver Deakin commented on HARMONY-6327:
----------------------------------------
Hi Ray,
I think the sendfile function you have found there is a different system call to the send_file we are using in the AIX block - it takes 4 parameters and returns a size value, where as send_file takes 3 parameters and returns 0 or -1.
I found this thread on an AIX user group:
http://unix.derkeiler.com/Newsgroups/comp.unix.aix/2003-07/0645.html
Which has the same link I gave above for the AIX reference, so I think the zOS and AIX send_file functions behave in the same way and should have the same code.
> [classlib][nio]FileChannelTest failed on z/OS
> ---------------------------------------------
>
> Key: HARMONY-6327
> URL: https://issues.apache.org/jira/browse/HARMONY-6327
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: z/OS platform
> Reporter: Ray Chen
> Assignee: Oliver Deakin
> Attachments: 6327.diff
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Failed on FileChannelTest.test_transferToJJLWritableByteChannel_SocketChannel
> Both line 3062 & 3063 failed
> Line 3062: 36 is expected but it gets 0
> Line 3063: 10 is expected but it gets 38
> Bug in modules/luni/src/main/native/luni/unix/OSFileSystemLinux32.c
> send_file() function returns 0 if success
> However it should return the count of trasfered bytes
> And transefer should not change the position value
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6327) [classlib][nio]FileChannelTest
failed on z/OS
Posted by "Ray Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ray Chen updated HARMONY-6327:
------------------------------
Attachment: 6327.diff
> [classlib][nio]FileChannelTest failed on z/OS
> ---------------------------------------------
>
> Key: HARMONY-6327
> URL: https://issues.apache.org/jira/browse/HARMONY-6327
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: z/OS platform
> Reporter: Ray Chen
> Attachments: 6327.diff
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Failed on FileChannelTest.test_transferToJJLWritableByteChannel_SocketChannel
> Both line 3062 & 3063 failed
> Line 3062: 36 is expected but it gets 0
> Line 3063: 10 is expected but it gets 38
> Bug in modules/luni/src/main/native/luni/unix/OSFileSystemLinux32.c
> send_file() function returns 0 if success
> However it should return the count of trasfered bytes
> And transefer should not change the position value
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-6327) [classlib][nio]FileChannelTest failed
on z/OS
Posted by "Ray Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ray Chen closed HARMONY-6327.
-----------------------------
Patch verified, Thank you,Oliver
> [classlib][nio]FileChannelTest failed on z/OS
> ---------------------------------------------
>
> Key: HARMONY-6327
> URL: https://issues.apache.org/jira/browse/HARMONY-6327
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M11
> Environment: z/OS platform
> Reporter: Ray Chen
> Assignee: Oliver Deakin
> Fix For: 5.0M12
>
> Attachments: 6327.diff, 6327_v2.diff
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Failed on FileChannelTest.test_transferToJJLWritableByteChannel_SocketChannel
> Both line 3062 & 3063 failed
> Line 3062: 36 is expected but it gets 0
> Line 3063: 10 is expected but it gets 38
> Bug in modules/luni/src/main/native/luni/unix/OSFileSystemLinux32.c
> send_file() function returns 0 if success
> However it should return the count of trasfered bytes
> And transefer should not change the position value
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6327) [classlib][nio]FileChannelTest
failed on z/OS
Posted by "Ray Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750333#action_12750333 ]
Ray Chen commented on HARMONY-6327:
-----------------------------------
Hi Oliver,
I found some links of AIX, it says the send_file function is not implemented
on AIX. So I separate the code into two blocks for AIX and z/OS.
I don't have AIX machine right now, may be we can test it later.
Here is the link I refer to
http://www1.hrz.tu-darmstadt.de/hhlr/doku/sw/apidiffs.html#sendfile
--
Ray Chen
MSN:clraychen@hotmail.com <MS...@hotmail.com>
Email:clarychen@gmail.com <Em...@gmail.com>
> [classlib][nio]FileChannelTest failed on z/OS
> ---------------------------------------------
>
> Key: HARMONY-6327
> URL: https://issues.apache.org/jira/browse/HARMONY-6327
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: z/OS platform
> Reporter: Ray Chen
> Assignee: Oliver Deakin
> Attachments: 6327.diff
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Failed on FileChannelTest.test_transferToJJLWritableByteChannel_SocketChannel
> Both line 3062 & 3063 failed
> Line 3062: 36 is expected but it gets 0
> Line 3063: 10 is expected but it gets 38
> Bug in modules/luni/src/main/native/luni/unix/OSFileSystemLinux32.c
> send_file() function returns 0 if success
> However it should return the count of trasfered bytes
> And transefer should not change the position value
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6327) [classlib][nio]FileChannelTest
failed on z/OS
Posted by "Oliver Deakin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750327#action_12750327 ]
Oliver Deakin commented on HARMONY-6327:
----------------------------------------
Hi Ray,
Does AIX also need the same changes? I have had a look for the technical documentation on this function and the only resources I can find seem to indication that send_file always returns 0 on success and -1 on failure:
http://publib16.boulder.ibm.com/doc_link/en_US/a_doc_lib/libs/commtrf2/send_file.htm
Do you think we should change the AIX block also?
Also, since positionBack is only used in the zOS block, it should probably only be defined and set there, rather than for all platforms. Do you agree?
> [classlib][nio]FileChannelTest failed on z/OS
> ---------------------------------------------
>
> Key: HARMONY-6327
> URL: https://issues.apache.org/jira/browse/HARMONY-6327
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: z/OS platform
> Reporter: Ray Chen
> Assignee: Oliver Deakin
> Attachments: 6327.diff
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Failed on FileChannelTest.test_transferToJJLWritableByteChannel_SocketChannel
> Both line 3062 & 3063 failed
> Line 3062: 36 is expected but it gets 0
> Line 3063: 10 is expected but it gets 38
> Bug in modules/luni/src/main/native/luni/unix/OSFileSystemLinux32.c
> send_file() function returns 0 if success
> However it should return the count of trasfered bytes
> And transefer should not change the position value
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.