You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "tkalkirill (via GitHub)" <gi...@apache.org> on 2023/05/17 15:34:12 UTC
[GitHub] [ignite-3] tkalkirill opened a new pull request, #2082: IGNITE-19509 Get rid of reading configuration when calling methods MvTableStorage#getOrCreate*Index
tkalkirill opened a new pull request, #2082:
URL: https://github.com/apache/ignite-3/pull/2082
https://issues.apache.org/jira/browse/IGNITE-19509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill merged pull request #2082: IGNITE-19509 Get rid of reading configuration when calling methods MvTableStorage#getOrCreate*Index
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill merged PR #2082:
URL: https://github.com/apache/ignite-3/pull/2082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] rpuch commented on a diff in pull request #2082: IGNITE-19509 Get rid of reading configuration when calling methods MvTableStorage#getOrCreate*Index
Posted by "rpuch (via GitHub)" <gi...@apache.org>.
rpuch commented on code in PR #2082:
URL: https://github.com/apache/ignite-3/pull/2082#discussion_r1197476596
##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuilder.java:
##########
@@ -98,10 +99,10 @@ void stop() {
/**
* Initializes the build of the index.
*/
- void startIndexBuild(TableIndexView tableIndexView, TableImpl table) {
+ void startIndexBuild(TableIndexView tableIndexView, TableImpl table, IndexDescriptor indexDescriptor) {
Review Comment:
Ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] rpuch commented on a diff in pull request #2082: IGNITE-19509 Get rid of reading configuration when calling methods MvTableStorage#getOrCreate*Index
Posted by "rpuch (via GitHub)" <gi...@apache.org>.
rpuch commented on code in PR #2082:
URL: https://github.com/apache/ignite-3/pull/2082#discussion_r1197449171
##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuilder.java:
##########
@@ -98,10 +99,10 @@ void stop() {
/**
* Initializes the build of the index.
*/
- void startIndexBuild(TableIndexView tableIndexView, TableImpl table) {
+ void startIndexBuild(TableIndexView tableIndexView, TableImpl table, IndexDescriptor indexDescriptor) {
Review Comment:
It looks like `tableIndexView` is only used to obtain index ID, which we can now take from `indexDescriptor`. I suggest to remove `tableIndexView` from parameters and pass index ID directly to the components that need it (like `BuildIndexTask`). This will allow us to reduce the usage of configuration even further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #2082: IGNITE-19509 Get rid of reading configuration when calling methods MvTableStorage#getOrCreate*Index
Posted by "tkalkirill (via GitHub)" <gi...@apache.org>.
tkalkirill commented on code in PR #2082:
URL: https://github.com/apache/ignite-3/pull/2082#discussion_r1197475209
##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuilder.java:
##########
@@ -98,10 +99,10 @@ void stop() {
/**
* Initializes the build of the index.
*/
- void startIndexBuild(TableIndexView tableIndexView, TableImpl table) {
+ void startIndexBuild(TableIndexView tableIndexView, TableImpl table, IndexDescriptor indexDescriptor) {
Review Comment:
I think that in the near future this code will disappear, the building of indexes has changed a little in the https://github.com/apache/ignite-3/pull/2030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org