[GitHub] [druid] jwitko commented on a diff in pull request #13796: helm: Add customizable global and per-container env vars to helm chart

["jwitko (via GitHub)" <gi...@apache.org>]

jwitko commented on code in PR #13796:
URL: https://github.com/apache/druid/pull/13796#discussion_r1137207649


##########
helm/druid/templates/middleManager/statefulset.yaml:
##########
@@ -73,7 +73,7 @@ spec:
               topologyKey: kubernetes.io/hostname
               labelSelector:
                 matchLabels:
-                  app: "{{ template "druid.name" . }}"
+                  app: {{ template "druid.name" . | quote }}

Review Comment:
   quote can take a list and quote all the values but that almost certainly would never come into play here.  I personally just think its cleaner.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org