You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/09/07 09:46:47 UTC
[GitHub] [apisix-ingress-controller] Donghui0 opened a new issue #671: bug: recordStatus status is overwritten
Donghui0 opened a new issue #671:
URL: https://github.com/apache/apisix-ingress-controller/issues/671
### Issue description
Create an incorrect Route CRD, such as a parameter error in the plugin. recordStatus will be updated to **_resourceSyncAborted**. But in the handleSyncErr method, it is covered as **_resourceSynced**.
### Environment
* your apisix-ingress-controller version: 1.2
### Minimal test code / Steps to reproduce the issue
1. create incorrect Route CRD.
2. kubectl get apisixroute xxx -n namespace -o json
### What's the actual result? (including assertion message & call stack if applicable)
status.conditions[0].message is "Sync Successfully"
### What's the expected result?
status.conditions[0].message is err.Error()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] Donghui0 commented on issue #671: bug: recordStatus status is overwritten
Posted by GitBox <gi...@apache.org>.
Donghui0 commented on issue #671:
URL: https://github.com/apache/apisix-ingress-controller/issues/671#issuecomment-919741938
> When `errOrigin == nil`, it should be `_resourceSynced`, else should be `_resourceSyncAborted `
> cc
>
> https://github.com/apache/apisix-ingress-controller/blob/6a8658db1788c687c70c9f235601cc8224e0b38c/pkg/ingress/apisix_route.go#L275-L283
This code will not execute. line 268 `return` execute.
https://github.com/apache/apisix-ingress-controller/blob/5c9cdbe7fc2c28f3023d635dbbd9bc833388a2bf/pkg/ingress/apisix_route.go#L246-L293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #671: bug: recordStatus status is overwritten
Posted by GitBox <gi...@apache.org>.
tokers commented on issue #671:
URL: https://github.com/apache/apisix-ingress-controller/issues/671#issuecomment-914322523
@Donghui0 PR's welcome to solve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #671: bug: recordStatus status is overwritten
Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #671:
URL: https://github.com/apache/apisix-ingress-controller/issues/671#issuecomment-919723881
When `errOrigin == nil`, it should be `_resourceSynced`, else should be `_resourceSyncAborted `
cc https://github.com/apache/apisix-ingress-controller/blob/6a8658db1788c687c70c9f235601cc8224e0b38c/pkg/ingress/apisix_route.go#L275-L283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj closed issue #671: bug: recordStatus status is overwritten
Posted by GitBox <gi...@apache.org>.
gxthrj closed issue #671:
URL: https://github.com/apache/apisix-ingress-controller/issues/671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #671: bug: recordStatus status is overwritten
Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #671:
URL: https://github.com/apache/apisix-ingress-controller/issues/671#issuecomment-919758160
related to #682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #671: bug: recordStatus status is overwritten
Posted by GitBox <gi...@apache.org>.
gxthrj commented on issue #671:
URL: https://github.com/apache/apisix-ingress-controller/issues/671#issuecomment-986767928
close this issue as #706 has been merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org