You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Andy Goldstein (JIRA)" <ji...@apache.org> on 2011/06/06 19:39:59 UTC
[jira] [Created] (QPID-3293) ClientProperties.java:
READ_BUFFER_LIMIT_PROP_NAME and WRITE_BUFFER_LIMIT_PROP_NAME constants have
same value
ClientProperties.java: READ_BUFFER_LIMIT_PROP_NAME and WRITE_BUFFER_LIMIT_PROP_NAME constants have same value
-------------------------------------------------------------------------------------------------------------
Key: QPID-3293
URL: https://issues.apache.org/jira/browse/QPID-3293
Project: Qpid
Issue Type: Bug
Components: Java Client
Reporter: Andy Goldstein
In org.apache.qpid.configuration.ClientProperties, both READ_BUFFER_LIMIT_PROP_NAME and WRITE_BUFFER_LIMIT_PROP_NAME constants have same value ("qpid.read.buffer.limit"). Presumably WRITE_BUFFER_LIMIT_PROP_NAME should be something like "qpid.write.buffer.limit", right?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3293) restore ability to set client
connection send/receive buffer sizes
Posted by "Robbie Gemmell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211530#comment-13211530 ]
Robbie Gemmell commented on QPID-3293:
--------------------------------------
The properties mentioned in the original description were used for the 0-8/0-9 client and Java broker to control the ProtectIO functionality they had. That functionality was Mina specific, and was removed very shortly after this JIRA was raised. Our use of Mina followed not long after.
The properties Rajith referred to that were used in IoTransport were inadvertantly removed during the IO layer update that lead on to the eventual removal of Mina.
New properties should be added (not those used for ProtectIO) to allow controlling the buffer sizes, and support for the legacy properties restored for anyone upgrading.
> restore ability to set client connection send/receive buffer sizes
> ------------------------------------------------------------------
>
> Key: QPID-3293
> URL: https://issues.apache.org/jira/browse/QPID-3293
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.14
> Reporter: Andy Goldstein
> Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> In org.apache.qpid.configuration.ClientProperties, both READ_BUFFER_LIMIT_PROP_NAME and WRITE_BUFFER_LIMIT_PROP_NAME constants have same value ("qpid.read.buffer.limit"). Presumably WRITE_BUFFER_LIMIT_PROP_NAME should be something like "qpid.write.buffer.limit", right?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3293) restore ability to set client
connection send/receive buffer sizes
Posted by "Robbie Gemmell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-3293:
---------------------------------
Affects Version/s: 0.14
Fix Version/s: 0.15
Assignee: Robbie Gemmell
Summary: restore ability to set client connection send/receive buffer sizes (was: ClientProperties.java: READ_BUFFER_LIMIT_PROP_NAME and WRITE_BUFFER_LIMIT_PROP_NAME constants have same value)
> restore ability to set client connection send/receive buffer sizes
> ------------------------------------------------------------------
>
> Key: QPID-3293
> URL: https://issues.apache.org/jira/browse/QPID-3293
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.14
> Reporter: Andy Goldstein
> Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> In org.apache.qpid.configuration.ClientProperties, both READ_BUFFER_LIMIT_PROP_NAME and WRITE_BUFFER_LIMIT_PROP_NAME constants have same value ("qpid.read.buffer.limit"). Presumably WRITE_BUFFER_LIMIT_PROP_NAME should be something like "qpid.write.buffer.limit", right?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3293) ClientProperties.java:
READ_BUFFER_LIMIT_PROP_NAME and WRITE_BUFFER_LIMIT_PROP_NAME constants have
same value
Posted by "Rajith Attapattu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045097#comment-13045097 ]
Rajith Attapattu commented on QPID-3293:
----------------------------------------
Andy,
The IoTransport class used the property names directly instead of the constants from the above class.
The new ConnectionSettings class which sets the read and write buffer is not using property names either and they are not configurable as well.
I have some unfinished work for the java client configuration and will fix the above as part of it.
Rajith
> ClientProperties.java: READ_BUFFER_LIMIT_PROP_NAME and WRITE_BUFFER_LIMIT_PROP_NAME constants have same value
> -------------------------------------------------------------------------------------------------------------
>
> Key: QPID-3293
> URL: https://issues.apache.org/jira/browse/QPID-3293
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Reporter: Andy Goldstein
>
> In org.apache.qpid.configuration.ClientProperties, both READ_BUFFER_LIMIT_PROP_NAME and WRITE_BUFFER_LIMIT_PROP_NAME constants have same value ("qpid.read.buffer.limit"). Presumably WRITE_BUFFER_LIMIT_PROP_NAME should be something like "qpid.write.buffer.limit", right?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3293) restore ability to set client
connection send/receive buffer sizes
Posted by "Robbie Gemmell (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell reassigned QPID-3293:
------------------------------------
Assignee: Keith Wall (was: Robbie Gemmell)
Keith, could you review this please?
Thanks,
Robbie
> restore ability to set client connection send/receive buffer sizes
> ------------------------------------------------------------------
>
> Key: QPID-3293
> URL: https://issues.apache.org/jira/browse/QPID-3293
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.14
> Reporter: Andy Goldstein
> Assignee: Keith Wall
> Fix For: 0.15
>
>
> NOTE: original description below, see comments for updated scope mentioned in the title.
> In org.apache.qpid.configuration.ClientProperties, both READ_BUFFER_LIMIT_PROP_NAME and WRITE_BUFFER_LIMIT_PROP_NAME constants have same value ("qpid.read.buffer.limit"). Presumably WRITE_BUFFER_LIMIT_PROP_NAME should be something like "qpid.write.buffer.limit", right?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3293) restore ability to set client
connection send/receive buffer sizes
Posted by "Robbie Gemmell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-3293:
---------------------------------
Description:
NOTE: original description below, see comments for updated scope mentioned in the title.
In org.apache.qpid.configuration.ClientProperties, both READ_BUFFER_LIMIT_PROP_NAME and WRITE_BUFFER_LIMIT_PROP_NAME constants have same value ("qpid.read.buffer.limit"). Presumably WRITE_BUFFER_LIMIT_PROP_NAME should be something like "qpid.write.buffer.limit", right?
was:In org.apache.qpid.configuration.ClientProperties, both READ_BUFFER_LIMIT_PROP_NAME and WRITE_BUFFER_LIMIT_PROP_NAME constants have same value ("qpid.read.buffer.limit"). Presumably WRITE_BUFFER_LIMIT_PROP_NAME should be something like "qpid.write.buffer.limit", right?
> restore ability to set client connection send/receive buffer sizes
> ------------------------------------------------------------------
>
> Key: QPID-3293
> URL: https://issues.apache.org/jira/browse/QPID-3293
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.14
> Reporter: Andy Goldstein
> Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> NOTE: original description below, see comments for updated scope mentioned in the title.
> In org.apache.qpid.configuration.ClientProperties, both READ_BUFFER_LIMIT_PROP_NAME and WRITE_BUFFER_LIMIT_PROP_NAME constants have same value ("qpid.read.buffer.limit"). Presumably WRITE_BUFFER_LIMIT_PROP_NAME should be something like "qpid.write.buffer.limit", right?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3293) restore ability to set client
connection send/receive buffer sizes
Posted by "Robbie Gemmell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-3293:
---------------------------------
Status: Ready To Review (was: In Progress)
> restore ability to set client connection send/receive buffer sizes
> ------------------------------------------------------------------
>
> Key: QPID-3293
> URL: https://issues.apache.org/jira/browse/QPID-3293
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.14
> Reporter: Andy Goldstein
> Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> NOTE: original description below, see comments for updated scope mentioned in the title.
> In org.apache.qpid.configuration.ClientProperties, both READ_BUFFER_LIMIT_PROP_NAME and WRITE_BUFFER_LIMIT_PROP_NAME constants have same value ("qpid.read.buffer.limit"). Presumably WRITE_BUFFER_LIMIT_PROP_NAME should be something like "qpid.write.buffer.limit", right?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3293) restore ability to set client
connection send/receive buffer sizes
Posted by "Keith Wall (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall resolved QPID-3293.
------------------------------
Resolution: Fixed
Changes look good to me.
> restore ability to set client connection send/receive buffer sizes
> ------------------------------------------------------------------
>
> Key: QPID-3293
> URL: https://issues.apache.org/jira/browse/QPID-3293
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.14
> Reporter: Andy Goldstein
> Assignee: Keith Wall
> Fix For: 0.15
>
>
> NOTE: original description below, see comments for updated scope mentioned in the title.
> In org.apache.qpid.configuration.ClientProperties, both READ_BUFFER_LIMIT_PROP_NAME and WRITE_BUFFER_LIMIT_PROP_NAME constants have same value ("qpid.read.buffer.limit"). Presumably WRITE_BUFFER_LIMIT_PROP_NAME should be something like "qpid.write.buffer.limit", right?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org