You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/12 20:35:16 UTC

[GitHub] [beam] rohdesamuel commented on a change in pull request #12414: [BEAM-10603] Fix BCJ to stop caching when the cache signature has changed.

rohdesamuel commented on a change in pull request #12414:
URL: https://github.com/apache/beam/pull/12414#discussion_r469526548



##########
File path: sdks/python/apache_beam/runners/interactive/background_caching_job.py
##########
@@ -182,7 +182,9 @@ def is_cache_complete(pipeline_id):
   cache_changed = is_source_to_cache_changed(
       user_pipeline, update_cached_source_signature=False)
 
-  return is_done and not cache_changed
+  # Stop reading from the cache is the background job is done or the underlying

Review comment:
       Done. Force pushed this change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org