You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Christian Taedcke (Created) (JIRA)" <ji...@apache.org> on 2012/02/28 20:53:46 UTC
[jira] [Created] (THRIFT-1524) TNonBlockingServer does not compile
in Visual Studio 2010
TNonBlockingServer does not compile in Visual Studio 2010
---------------------------------------------------------
Key: THRIFT-1524
URL: https://issues.apache.org/jira/browse/THRIFT-1524
Project: Thrift
Issue Type: Bug
Components: C++ - Library
Affects Versions: 0.9
Environment: Windows XP, Visual Studio 2010
Reporter: Christian Taedcke
Since Revision 1241171 TNonBlockingServer does not compile in Visual Studio 2010. The return value of ::close(SOCKET) is used in an comparison. This results in the following errors:
..\thrift\lib\cpp\src\server\tnonblockingserver.cpp(1270): error C2120
..\thrift\lib\cpp\src\server\tnonblockingserver.cpp(1279): error C2120
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1524) TNonBlockingServer does not compile
in Visual Studio 2010
Posted by "Christian Taedcke (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Taedcke updated THRIFT-1524:
--------------------------------------
Attachment: close_call_namespace.patch
close_call_namespace.patch is an optional cleanup patch. All calls to close(SOCKET) are substituted with ::close(SOCKET) in TNonBlockingServer.cpp.
> TNonBlockingServer does not compile in Visual Studio 2010
> ---------------------------------------------------------
>
> Key: THRIFT-1524
> URL: https://issues.apache.org/jira/browse/THRIFT-1524
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9
> Environment: Windows XP, Visual Studio 2010
> Reporter: Christian Taedcke
> Attachments: THRIFT-1524.patch, close_call_namespace.patch
>
>
> Since Revision 1241171 TNonBlockingServer does not compile in Visual Studio 2010. The return value of ::close(SOCKET) is used in an comparison. This results in the following errors:
> ..\thrift\lib\cpp\src\server\tnonblockingserver.cpp(1270): error C2120
> ..\thrift\lib\cpp\src\server\tnonblockingserver.cpp(1279): error C2120
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1524) TNonBlockingServer does not compile
in Visual Studio 2010
Posted by "Christian Taedcke (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Taedcke updated THRIFT-1524:
--------------------------------------
Attachment: THRIFT-1524.patch
This patch reverts the function void close(SOCKET) to int close (SOCKET), so that Visual Studio 2010 compiles TNonBlockingServer.
> TNonBlockingServer does not compile in Visual Studio 2010
> ---------------------------------------------------------
>
> Key: THRIFT-1524
> URL: https://issues.apache.org/jira/browse/THRIFT-1524
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9
> Environment: Windows XP, Visual Studio 2010
> Reporter: Christian Taedcke
> Attachments: THRIFT-1524.patch
>
>
> Since Revision 1241171 TNonBlockingServer does not compile in Visual Studio 2010. The return value of ::close(SOCKET) is used in an comparison. This results in the following errors:
> ..\thrift\lib\cpp\src\server\tnonblockingserver.cpp(1270): error C2120
> ..\thrift\lib\cpp\src\server\tnonblockingserver.cpp(1279): error C2120
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1524) TNonBlockingServer does not compile
in Visual Studio 2010
Posted by "Christian Taedcke (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Taedcke closed THRIFT-1524.
-------------------------------------
Resolution: Fixed
Fix Version/s: 0.9
Thanks for applying the patches. It compiles now in VS 2010.
> TNonBlockingServer does not compile in Visual Studio 2010
> ---------------------------------------------------------
>
> Key: THRIFT-1524
> URL: https://issues.apache.org/jira/browse/THRIFT-1524
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.9
> Environment: Windows XP, Visual Studio 2010
> Reporter: Christian Taedcke
> Fix For: 0.9
>
> Attachments: THRIFT-1524.patch, close_call_namespace.patch
>
>
> Since Revision 1241171 TNonBlockingServer does not compile in Visual Studio 2010. The return value of ::close(SOCKET) is used in an comparison. This results in the following errors:
> ..\thrift\lib\cpp\src\server\tnonblockingserver.cpp(1270): error C2120
> ..\thrift\lib\cpp\src\server\tnonblockingserver.cpp(1279): error C2120
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira