You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Evgeny S. Sidorenko (JIRA)" <ji...@apache.org> on 2006/09/17 19:25:23 UTC
[jira] Created: (HARMONY-1481) [classlib][sound] Class MidiSystem
and some utils
[classlib][sound] Class MidiSystem and some utils
-------------------------------------------------
Key: HARMONY-1481
URL: http://issues.apache.org/jira/browse/HARMONY-1481
Project: Harmony
Issue Type: Improvement
Components: Classlib
Reporter: Evgeny S. Sidorenko
Patch MidiSystem.patch.txt contains realization of class MidiSystem.
Patch org.apache.harmony.sound.utils.patch.txt contains some utilities that helps to works with classes MidiSystem and AudioSystem
For this time this patch doesn't support internationalization
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Commented: (HARMONY-1481) [classlib][sound] Class MidiSystem and some utils
Posted by "Evgeny S. Sidorenko" <ev...@gmail.com>.
Hi, Nathan!
I considered your remarks, and laid out new patch. Could you look it?
2006/9/18, Evgeny S. Sidorenko (JIRA) <ji...@apache.org>:
> [ http://issues.apache.org/jira/browse/HARMONY-1481?page=comments#action_12435380 ]
>
> Evgeny S. Sidorenko commented on HARMONY-1481:
> ----------------------------------------------
>
> 1. OK
> 2. The first variant of my class doesn't include static fields, but in this case it work enough long... But if optimization doesn't important for this time, I can to rewrite this method; I'll eliminate the static fields.
>
> > [classlib][sound] Class MidiSystem and some utils
> > -------------------------------------------------
> >
> > Key: HARMONY-1481
> > URL: http://issues.apache.org/jira/browse/HARMONY-1481
> > Project: Harmony
> > Issue Type: Improvement
> > Components: Classlib
> > Reporter: Evgeny S. Sidorenko
> > Assigned To: Nathan Beyer
> > Attachments: MidiSystem.patch.txt, org.apache.harmony.sound.utils.patch.txt
> >
> >
> > Patch MidiSystem.patch.txt contains realization of class MidiSystem.
> > Patch org.apache.harmony.sound.utils.patch.txt contains some utilities that helps to works with classes MidiSystem and AudioSystem
> > For this time this patch doesn't support internationalization
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
--
Best regards,
Evgeny
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-unsubscribe@incubator.apache.org
For additional commands, e-mail: harmony-dev-help@incubator.apache.org
[jira] Commented: (HARMONY-1481) [classlib][sound] Class MidiSystem
and some utils
Posted by "Evgeny S. Sidorenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1481?page=comments#action_12438518 ]
Evgeny S. Sidorenko commented on HARMONY-1481:
----------------------------------------------
OK, it's all right.
> [classlib][sound] Class MidiSystem and some utils
> -------------------------------------------------
>
> Key: HARMONY-1481
> URL: http://issues.apache.org/jira/browse/HARMONY-1481
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Evgeny S. Sidorenko
> Assigned To: Nathan Beyer
> Attachments: fixed.MidiSystem.patch.txt, fixed.org.apache.harmony.sound.utils.patch.txt, MidiSystem.patch.txt, org.apache.harmony.sound.utils.patch.txt
>
>
> Patch MidiSystem.patch.txt contains realization of class MidiSystem.
> Patch org.apache.harmony.sound.utils.patch.txt contains some utilities that helps to works with classes MidiSystem and AudioSystem
> For this time this patch doesn't support internationalization
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1481) [classlib][sound] Class MidiSystem
and some utils
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1481?page=comments#action_12435368 ]
Nathan Beyer commented on HARMONY-1481:
---------------------------------------
Here are few comments about this patch that I'd like to see resolved before moving ahead.
1. Consider using generics in the ProviderService classes methods. For example, the getProviders method could using this signature instead: public static List<? extends MidiDeviceProvider> getProviders(String providerName).
2. MidiSystem contains some thread races. Specifically, the code is checking the static fields for null and then doing a lookup of the providers and assigning the fields. This code either needs synchronization to protect these fields properly or the static fields should just be eliminated altogether. I would suggest the just eliminating the static fields altogether. This will make the code more simple and straightforward; optimizations can always be made later.
> [classlib][sound] Class MidiSystem and some utils
> -------------------------------------------------
>
> Key: HARMONY-1481
> URL: http://issues.apache.org/jira/browse/HARMONY-1481
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Evgeny S. Sidorenko
> Assigned To: Nathan Beyer
> Attachments: MidiSystem.patch.txt, org.apache.harmony.sound.utils.patch.txt
>
>
> Patch MidiSystem.patch.txt contains realization of class MidiSystem.
> Patch org.apache.harmony.sound.utils.patch.txt contains some utilities that helps to works with classes MidiSystem and AudioSystem
> For this time this patch doesn't support internationalization
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1481) [classlib][sound] Class MidiSystem
and some utils
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1481?page=all ]
Nathan Beyer reassigned HARMONY-1481:
-------------------------------------
Assignee: Nathan Beyer
> [classlib][sound] Class MidiSystem and some utils
> -------------------------------------------------
>
> Key: HARMONY-1481
> URL: http://issues.apache.org/jira/browse/HARMONY-1481
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Evgeny S. Sidorenko
> Assigned To: Nathan Beyer
> Attachments: MidiSystem.patch.txt, org.apache.harmony.sound.utils.patch.txt
>
>
> Patch MidiSystem.patch.txt contains realization of class MidiSystem.
> Patch org.apache.harmony.sound.utils.patch.txt contains some utilities that helps to works with classes MidiSystem and AudioSystem
> For this time this patch doesn't support internationalization
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1481) [classlib][sound] Class MidiSystem
and some utils
Posted by "Evgeny S. Sidorenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1481?page=all ]
Evgeny S. Sidorenko updated HARMONY-1481:
-----------------------------------------
Attachment: MidiSystem.patch.txt
org.apache.harmony.sound.utils.patch.txt
> [classlib][sound] Class MidiSystem and some utils
> -------------------------------------------------
>
> Key: HARMONY-1481
> URL: http://issues.apache.org/jira/browse/HARMONY-1481
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Evgeny S. Sidorenko
> Attachments: MidiSystem.patch.txt, org.apache.harmony.sound.utils.patch.txt
>
>
> Patch MidiSystem.patch.txt contains realization of class MidiSystem.
> Patch org.apache.harmony.sound.utils.patch.txt contains some utilities that helps to works with classes MidiSystem and AudioSystem
> For this time this patch doesn't support internationalization
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1481) [classlib][sound] Class MidiSystem
and some utils
Posted by "Evgeny S. Sidorenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1481?page=all ]
Evgeny S. Sidorenko updated HARMONY-1481:
-----------------------------------------
Attachment: fixed.MidiSystem.patch.txt
fixed.org.apache.harmony.sound.utils.patch.txt
The new patches with prefix fixed.* contain some improvements:
1. In the class MidiSystem I remove static fields
2. In the class ProviderService I remove static field jarFiles and correct class to work correctly in this case.
But I don't agree to change signature of method getProviders(String), because I use this method to get MidiDeviceProvider, MidiFileReader, MidiFileWriter, SoundbankReader and I want to use this method in the class AudioSystem too, and all of this are different types...
Of course, I can create the same method for all of this types/classes, but I think it's not good idea.
> [classlib][sound] Class MidiSystem and some utils
> -------------------------------------------------
>
> Key: HARMONY-1481
> URL: http://issues.apache.org/jira/browse/HARMONY-1481
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Evgeny S. Sidorenko
> Assigned To: Nathan Beyer
> Attachments: fixed.MidiSystem.patch.txt, fixed.org.apache.harmony.sound.utils.patch.txt, MidiSystem.patch.txt, org.apache.harmony.sound.utils.patch.txt
>
>
> Patch MidiSystem.patch.txt contains realization of class MidiSystem.
> Patch org.apache.harmony.sound.utils.patch.txt contains some utilities that helps to works with classes MidiSystem and AudioSystem
> For this time this patch doesn't support internationalization
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1481) [classlib][sound] Class MidiSystem
and some utils
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1481?page=all ]
Nathan Beyer resolved HARMONY-1481.
-----------------------------------
Resolution: Fixed
Patch applied with minor modifications; please verify. Thanks.
> [classlib][sound] Class MidiSystem and some utils
> -------------------------------------------------
>
> Key: HARMONY-1481
> URL: http://issues.apache.org/jira/browse/HARMONY-1481
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Evgeny S. Sidorenko
> Assigned To: Nathan Beyer
> Attachments: fixed.MidiSystem.patch.txt, fixed.org.apache.harmony.sound.utils.patch.txt, MidiSystem.patch.txt, org.apache.harmony.sound.utils.patch.txt
>
>
> Patch MidiSystem.patch.txt contains realization of class MidiSystem.
> Patch org.apache.harmony.sound.utils.patch.txt contains some utilities that helps to works with classes MidiSystem and AudioSystem
> For this time this patch doesn't support internationalization
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1481) [classlib][sound] Class MidiSystem
and some utils
Posted by "Evgeny S. Sidorenko (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1481?page=comments#action_12435380 ]
Evgeny S. Sidorenko commented on HARMONY-1481:
----------------------------------------------
1. OK
2. The first variant of my class doesn't include static fields, but in this case it work enough long... But if optimization doesn't important for this time, I can to rewrite this method; I'll eliminate the static fields.
> [classlib][sound] Class MidiSystem and some utils
> -------------------------------------------------
>
> Key: HARMONY-1481
> URL: http://issues.apache.org/jira/browse/HARMONY-1481
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Evgeny S. Sidorenko
> Assigned To: Nathan Beyer
> Attachments: MidiSystem.patch.txt, org.apache.harmony.sound.utils.patch.txt
>
>
> Patch MidiSystem.patch.txt contains realization of class MidiSystem.
> Patch org.apache.harmony.sound.utils.patch.txt contains some utilities that helps to works with classes MidiSystem and AudioSystem
> For this time this patch doesn't support internationalization
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira