[GitHub] [superset] yardz commented on a change in pull request #13220: test: Switching FlashProvider to function component & creating tests

[GitBox <gi...@apache.org>]

yardz commented on a change in pull request #13220:
URL: https://github.com/apache/superset/pull/13220#discussion_r578857107



##########
File path: superset-frontend/src/explore/components/ExploreViewContainer.jsx
##########
@@ -146,11 +147,11 @@ const getWindowSize = () => ({
 function useWindowSize({ delayMs = 250 } = {}) {
   const [size, setSize] = useState(getWindowSize());
 
-  useEffect(() => {
+  useComponentDidMount(() => {
     const onWindowResize = debounce(() => setSize(getWindowSize()), delayMs);
     window.addEventListener('resize', onWindowResize);
     return () => window.removeEventListener('resize', onWindowResize);
-  }, []);
+  });

Review comment:
       @suddjian I understand your point, however I did not refactor this file (if I had even done it I would have passed it to typescript).
   I just kept the same logic / behavior that already existed, if "this behavior is bad" I believe it would be a matter for another PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org