You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by we...@apache.org on 2017/07/03 16:16:20 UTC
arrow git commit: ARROW-1179: C++: Add missing virtual destructors
Repository: arrow
Updated Branches:
refs/heads/master 9e4906f7f -> 2e5ddfe7d
ARROW-1179: C++: Add missing virtual destructors
Author: Uwe L. Korn <uw...@xhochy.com>
Closes #803 from xhochy/ARROW-1179 and squashes the following commits:
69f283f1 [Uwe L. Korn] Add another destructor
ce71464e [Uwe L. Korn] Add virtual destructor to KVMetadata
Project: http://git-wip-us.apache.org/repos/asf/arrow/repo
Commit: http://git-wip-us.apache.org/repos/asf/arrow/commit/2e5ddfe7
Tree: http://git-wip-us.apache.org/repos/asf/arrow/tree/2e5ddfe7
Diff: http://git-wip-us.apache.org/repos/asf/arrow/diff/2e5ddfe7
Branch: refs/heads/master
Commit: 2e5ddfe7dc7c653ebf97b95a62e7da8909fc7ac8
Parents: 9e4906f
Author: Uwe L. Korn <uw...@xhochy.com>
Authored: Mon Jul 3 12:16:15 2017 -0400
Committer: Wes McKinney <we...@twosigma.com>
Committed: Mon Jul 3 12:16:15 2017 -0400
----------------------------------------------------------------------
cpp/src/arrow/type.h | 1 +
cpp/src/arrow/util/key_value_metadata.h | 1 +
2 files changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/arrow/blob/2e5ddfe7/cpp/src/arrow/type.h
----------------------------------------------------------------------
diff --git a/cpp/src/arrow/type.h b/cpp/src/arrow/type.h
index 9ae8374..70e8644 100644
--- a/cpp/src/arrow/type.h
+++ b/cpp/src/arrow/type.h
@@ -694,6 +694,7 @@ class ARROW_EXPORT Schema {
public:
explicit Schema(const std::vector<std::shared_ptr<Field>>& fields,
const std::shared_ptr<const KeyValueMetadata>& metadata = nullptr);
+ virtual ~Schema() = default;
// Returns true if all of the schema fields are equal
bool Equals(const Schema& other) const;
http://git-wip-us.apache.org/repos/asf/arrow/blob/2e5ddfe7/cpp/src/arrow/util/key_value_metadata.h
----------------------------------------------------------------------
diff --git a/cpp/src/arrow/util/key_value_metadata.h b/cpp/src/arrow/util/key_value_metadata.h
index bae4ad8..a2a4623 100644
--- a/cpp/src/arrow/util/key_value_metadata.h
+++ b/cpp/src/arrow/util/key_value_metadata.h
@@ -35,6 +35,7 @@ class ARROW_EXPORT KeyValueMetadata {
KeyValueMetadata(
const std::vector<std::string>& keys, const std::vector<std::string>& values);
explicit KeyValueMetadata(const std::unordered_map<std::string, std::string>& map);
+ virtual ~KeyValueMetadata() = default;
void ToUnorderedMap(std::unordered_map<std::string, std::string>* out) const;